Re: [PATCH v2] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-25 Thread Dan Carpenter
Greg deleted your patch already... regards, dan carpenter

Re: [PATCH v2] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-25 Thread Kirill Marinushkin
On 04/25/18 08:16, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 09:57:29PM +0200, Kirill Marinushkin wrote: >> In the current implementation, vchi_instance is inited during the first >> call of bcm2835_audio_open_connection(), and is never freed. It causes a >> memory leak when the module `s

Re: [PATCH v2] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-24 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 09:57:29PM +0200, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > > Here is how this comm

[PATCH v2] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-24 Thread Kirill Marinushkin
In the current implementation, vchi_instance is inited during the first call of bcm2835_audio_open_connection(), and is never freed. It causes a memory leak when the module `snd_bcm2835` is removed. Here is how this commit fixes it: * the VCHI context (including vchi_instance) is created once in