Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Ian Abbott
On 2013-02-22 14:26, Kumar amit mehta wrote: On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote: On 2013-02-22 06:07, Kumar Amit Mehta wrote: This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Kumar amit mehta
On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote: > On 2013-02-22 06:07, Kumar Amit Mehta wrote: > >This patch fixes an instance of DMA buffer on stack(being passed to > >usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. > > > > Looks good here too. > >

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Ian Abbott
On 2013-02-22 06:07, Kumar Amit Mehta wrote: This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. Looks good here too. Reviewed-by: Ian Abbott Would you mind doing the same for usbdux.c and usbduxfast.c?

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Ian Abbott
On 2013-02-22 06:07, Kumar Amit Mehta wrote: This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. Looks good here too. Reviewed-by: Ian Abbott abbo...@mev.co.uk Would you mind doing the same for usbdux.c

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Kumar amit mehta
On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote: On 2013-02-22 06:07, Kumar Amit Mehta wrote: This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. Looks good here too. Reviewed-by: Ian

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-22 Thread Ian Abbott
On 2013-02-22 14:26, Kumar amit mehta wrote: On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote: On 2013-02-22 06:07, Kumar Amit Mehta wrote: This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-21 Thread Dan Carpenter
Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-21 Thread Kumar Amit Mehta
This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. Signed-off-by: Kumar Amit Mehta --- drivers/staging/comedi/drivers/usbduxsigma.c | 27 -- 1 file changed, 17 insertions(+), 10

[PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-21 Thread Kumar Amit Mehta
This patch fixes an instance of DMA buffer on stack(being passed to usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch. Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com --- drivers/staging/comedi/drivers/usbduxsigma.c | 27 -- 1 file changed, 17

Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

2013-02-21 Thread Dan Carpenter
Looks good. Reviewed-by: Dan Carpenter dan.carpen...@oracle.com regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read