Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Kees Cook
On Fri, Nov 3, 2017 at 2:49 PM, Bryan O'Donoghue wrote: > > > On 03/11/17 20:21, Kees Cook wrote: >> >> On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: >>> >>> On Mon, Oct 30, 2017 at 5:01 PM, wrote:

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Kees Cook
On Fri, Nov 3, 2017 at 2:49 PM, Bryan O'Donoghue wrote: > > > On 03/11/17 20:21, Kees Cook wrote: >> >> On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: >>> >>> On Mon, Oct 30, 2017 at 5:01 PM, wrote: There's a separate change to loopback.c an old patch ARAIR that will subtract

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Bryan O'Donoghue
On 03/11/17 20:21, Kees Cook wrote: On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: On Mon, Oct 30, 2017 at 5:01 PM, wrote: There's a separate change to loopback.c an old patch ARAIR that will subtract use of the timer from

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Bryan O'Donoghue
On 03/11/17 20:21, Kees Cook wrote: On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: On Mon, Oct 30, 2017 at 5:01 PM, wrote: There's a separate change to loopback.c an old patch ARAIR that will subtract use of the timer from loopback.c so you can skip that bit. Okay, cool. Since the

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: > On Mon, Oct 30, 2017 at 5:01 PM, wrote: >> There's a separate change to loopback.c an old patch ARAIR that will >> subtract use of the timer from loopback.c so you can skip that bit. > >

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-11-03 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote: > On Mon, Oct 30, 2017 at 5:01 PM, wrote: >> There's a separate change to loopback.c an old patch ARAIR that will >> subtract use of the timer from loopback.c so you can skip that bit. > > Okay, cool. Since the operation.c change is trivial,

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:01 PM, wrote: > On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook > wrote: >>On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >>> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:01 PM, wrote: > On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook > wrote: >>On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >>> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: On 30/10/17 11:38, Johan Hovold wrote: > On

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread pure . logic
On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook wrote: >On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >>> >>> >>> On 30/10/17 11:38, Johan Hovold wrote: >>> > On Mon, Oct

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread pure . logic
On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook wrote: >On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >>> >>> >>> On 30/10/17 11:38, Johan Hovold wrote: >>> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >> >> >> On 30/10/17 11:38, Johan Hovold wrote: >> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: >> >> On 30/10/17 11:32, Johan Hovold

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >> >> >> On 30/10/17 11:38, Johan Hovold wrote: >> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: >> >> On 30/10/17 11:32, Johan Hovold wrote: >> >>> The

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: > > > On 30/10/17 11:38, Johan Hovold wrote: > > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: > >> On 30/10/17 11:32, Johan Hovold wrote: > >>> The right thing to do here is to respin your patch from last year

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: > > > On 30/10/17 11:38, Johan Hovold wrote: > > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: > >> On 30/10/17 11:32, Johan Hovold wrote: > >>> The right thing to do here is to respin your patch from last year

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Bryan O'Donoghue
On 30/10/17 11:38, Johan Hovold wrote: On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: On 30/10/17 11:32, Johan Hovold wrote: The right thing to do here is to respin your patch from last year which converts the loopback driver to use the timeout handling in greybus core.

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Bryan O'Donoghue
On 30/10/17 11:38, Johan Hovold wrote: On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: On 30/10/17 11:32, Johan Hovold wrote: The right thing to do here is to respin your patch from last year which converts the loopback driver to use the timeout handling in greybus core.

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: > On 30/10/17 11:32, Johan Hovold wrote: > > The right thing to do here is to respin your patch from last year which > > converts the loopback driver to use the timeout handling in greybus > > core. > > Actually I wasn't clear if

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: > On 30/10/17 11:32, Johan Hovold wrote: > > The right thing to do here is to respin your patch from last year which > > converts the loopback driver to use the timeout handling in greybus > > core. > > Actually I wasn't clear if

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
[ Resend to Bryan's nexus-software address ] On Tue, Oct 24, 2017 at 04:54:59PM +0100, Bryan O'Donoghue wrote: > On 24/10/17 15:49, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Bryan O'Donoghue
On 30/10/17 11:32, Johan Hovold wrote: The right thing to do here is to respin your patch from last year which converts the loopback driver to use the timeout handling in greybus core. Actually I wasn't clear if you wanted to to that yourself aswell as the rest if it. But sure I can do that

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
[ Resend to Bryan's nexus-software address ] On Tue, Oct 24, 2017 at 04:54:59PM +0100, Bryan O'Donoghue wrote: > On 24/10/17 15:49, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Bryan O'Donoghue
On 30/10/17 11:32, Johan Hovold wrote: The right thing to do here is to respin your patch from last year which converts the loopback driver to use the timeout handling in greybus core. Actually I wasn't clear if you wanted to to that yourself aswell as the rest if it. But sure I can do that

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Tue, Oct 24, 2017 at 04:54:59PM +0100, Bryan O'Donoghue wrote: > On 24/10/17 15:49, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass the timer pointer

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Johan Hovold
On Tue, Oct 24, 2017 at 04:54:59PM +0100, Bryan O'Donoghue wrote: > On 24/10/17 15:49, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass the timer pointer

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 15:49, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Bryan O'Donoghue
On 24/10/17 15:49, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc:

[PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue"

[PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Bryan O'Donoghue" Cc: Johan Hovold Cc: Alex Elder Cc: