Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:07:08PM +0530, Mitali Borkar wrote: > On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote: > > On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > > simpler form i.e. boolean e

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Mitali Borkar
On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote: > On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported by chec

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote: > Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e. boolean expression. This makes code more readable > alternative. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > Changes from v1:- added poi

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e. boolean expression. This makes code more readable > alternative. > Reported by checkpatch. Checkpatch did not report this specific problem, Ju

[PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Mitali Borkar
Fixed Comparison to NULL can be written as '!...' by replacing it with simpler form i.e. boolean expression. This makes code more readable alternative. Reported by checkpatch. Signed-off-by: Mitali Borkar --- Changes from v1:- added pointer to the function, which was missed during fixing v1. dr