Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Borislav Petkov
On Tue, Apr 20, 2021 at 09:15:41PM +0800, Chen Yu wrote: > This patch was sent to Len and it is not in public repo yet. If that thing were in a public repo, you'd have the advantage of pointing people to it and they could be testing patches. -- Regards/Gruss, Boris. SUSE Software Solutions

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Calvin Walton
On Tue, 2021-04-20 at 22:37 +0800, Chen Yu wrote: > On Tue, Apr 20, 2021 at 09:28:06AM -0400, Calvin Walton wrote: > > This patch has the same issue I noticed with the initial revision > > of > > Terry's patch - the idx_to_offset function returns type int (32-bit > > signed), but

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Chen Yu
On Tue, Apr 20, 2021 at 09:28:06AM -0400, Calvin Walton wrote: > On Tue, 2021-04-20 at 21:15 +0800, Chen Yu wrote: > > > > Okay. I would vote for the the patch from Bas as it was a combined > > work from two > > authors and tested by several AMD users. But let me paste it here too > > for Artem

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Artem S. Tashkinov
On 4/20/21 1:15 PM, Chen Yu wrote: On Tue, Apr 20, 2021 at 10:07:01AM +0200, Borislav Petkov wrote: On Tue, Apr 20, 2021 at 10:03:36AM +0800, Chen Yu wrote: On Mon, Apr 19, 2021 at 02:58:12PM -0500, Terry Bowman wrote: Turbostat fails to correctly collect and display RAPL summary information

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Calvin Walton
On Mon, 2021-04-19 at 14:58 -0500, Terry Bowman wrote: > Turbostat fails to correctly collect and display RAPL summary > information > on Family 17h and 19h AMD processors. Running turbostat on these > processors > returns immediately. If turbostat is working correctly then RAPL > summary > data

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Calvin Walton
On Tue, 2021-04-20 at 21:15 +0800, Chen Yu wrote: > > Okay. I would vote for the the patch from Bas as it was a combined > work from two > authors and tested by several AMD users. But let me paste it here too > for Artem to > see if this also works for him: > > > From

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Chen Yu
On Tue, Apr 20, 2021 at 10:07:01AM +0200, Borislav Petkov wrote: > On Tue, Apr 20, 2021 at 10:03:36AM +0800, Chen Yu wrote: > > On Mon, Apr 19, 2021 at 02:58:12PM -0500, Terry Bowman wrote: > > > Turbostat fails to correctly collect and display RAPL summary information > > > on Family 17h and 19h

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-20 Thread Borislav Petkov
On Tue, Apr 20, 2021 at 10:03:36AM +0800, Chen Yu wrote: > On Mon, Apr 19, 2021 at 02:58:12PM -0500, Terry Bowman wrote: > > Turbostat fails to correctly collect and display RAPL summary information > > on Family 17h and 19h AMD processors. Running turbostat on these processors > > returns

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-19 Thread Chen Yu
On Mon, Apr 19, 2021 at 02:58:12PM -0500, Terry Bowman wrote: > Turbostat fails to correctly collect and display RAPL summary information > on Family 17h and 19h AMD processors. Running turbostat on these processors > returns immediately. If turbostat is working correctly then RAPL summary > data

Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-19 Thread calvin . walton
On Mon, 2021-04-19 at 14:58 -0500, Terry Bowman wrote: @@ -3281,7 +3326,7 @@ static int update_msr_sum(struct thread_data *t, struct core_data *c, struct pkg continue; ret = get_msr(cpu, offset, _cur); if (ret) { -   

[PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-19 Thread Terry Bowman
Turbostat fails to correctly collect and display RAPL summary information on Family 17h and 19h AMD processors. Running turbostat on these processors returns immediately. If turbostat is working correctly then RAPL summary data is displayed until the user provided command completes. If a command