Re: [PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-31 Thread Steven Rostedt
On Mon, 23 Oct 2017 16:41:22 -0400 Will Hawkins wrote: > Mr. Rostedt, > > Just wanted to make sure there was nothing else you thought I should > modify for this patch. If there is, please let me know. I am eager to > fix anything that you think could make it better! >

Re: [PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-31 Thread Steven Rostedt
On Mon, 23 Oct 2017 16:41:22 -0400 Will Hawkins wrote: > Mr. Rostedt, > > Just wanted to make sure there was nothing else you thought I should > modify for this patch. If there is, please let me know. I am eager to > fix anything that you think could make it better! > I already applied this

Re: [PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-23 Thread Will Hawkins
Mr. Rostedt, Just wanted to make sure there was nothing else you thought I should modify for this patch. If there is, please let me know. I am eager to fix anything that you think could make it better! I hope that you had a great weekend! Will On Fri, Oct 13, 2017 at 2:40 PM, Will Hawkins

Re: [PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-23 Thread Will Hawkins
Mr. Rostedt, Just wanted to make sure there was nothing else you thought I should modify for this patch. If there is, please let me know. I am eager to fix anything that you think could make it better! I hope that you had a great weekend! Will On Fri, Oct 13, 2017 at 2:40 PM, Will Hawkins

[PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-13 Thread Will Hawkins
In older versions of the kernel, event filtering by pid does not use the set_event_pid file. Instead, ftrace uses a common filter (created in make_pid_filter) to filter events based on PID. The syntax of the filter generated by this function is overly permissive. When filtering by pid, || is used

[PATCH v2] trace-cmd record: Fix syntax in make_pid_filter

2017-10-13 Thread Will Hawkins
In older versions of the kernel, event filtering by pid does not use the set_event_pid file. Instead, ftrace uses a common filter (created in make_pid_filter) to filter events based on PID. The syntax of the filter generated by this function is overly permissive. When filtering by pid, || is used