Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 19:22:36 +0200 Dominik Brodowski wrote: > > Added back original compare to not miss 32bit kernel syscalls > > s/32bit/32bit and 0-parameter syscalls. > > Looks good otherwise. > You want to send an Acked or Reviewed-by to my final patch

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 19:22:36 +0200 Dominik Brodowski wrote: > > Added back original compare to not miss 32bit kernel syscalls > > s/32bit/32bit and 0-parameter syscalls. > > Looks good otherwise. > You want to send an Acked or Reviewed-by to my final patch (v3). -- Steve

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 12:25:36 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 18, 2018 at 11:20:33AM -0400, Steven Rostedt escreveu: > > On Wed, 18 Apr 2018 12:17:16 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > This does the trick, by not using the

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 12:25:36 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 18, 2018 at 11:20:33AM -0400, Steven Rostedt escreveu: > > On Wed, 18 Apr 2018 12:17:16 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > This does the trick, by not using the main syscall routine, but one > >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 11:20:33AM -0400, Steven Rostedt escreveu: > On Wed, 18 Apr 2018 12:17:16 -0300 > Arnaldo Carvalho de Melo wrote: > > > This does the trick, by not using the main syscall routine, but one > > called from it and not renamed, should work with older kernels.

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 11:20:33AM -0400, Steven Rostedt escreveu: > On Wed, 18 Apr 2018 12:17:16 -0300 > Arnaldo Carvalho de Melo wrote: > > > This does the trick, by not using the main syscall routine, but one > > called from it and not renamed, should work with older kernels. > > > > This

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 12:17:16 -0300 Arnaldo Carvalho de Melo wrote: > This does the trick, by not using the main syscall routine, but one > called from it and not renamed, should work with older kernels. > > This test should be improved to look if the desired routine is in

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 12:17:16 -0300 Arnaldo Carvalho de Melo wrote: > This does the trick, by not using the main syscall routine, but one > called from it and not renamed, should work with older kernels. > > This test should be improved to look if the desired routine is in place, > if not just

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 12:02:12PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Apr 18, 2018 at 10:36:06AM -0400, Steven Rostedt escreveu: > > On Wed, 18 Apr 2018 09:53:22 -0300 > > Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 12:02:12PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Apr 18, 2018 at 10:36:06AM -0400, Steven Rostedt escreveu: > > On Wed, 18 Apr 2018 09:53:22 -0300 > > Arnaldo Carvalho de Melo wrote: > > > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 10:36:06AM -0400, Steven Rostedt escreveu: > On Wed, 18 Apr 2018 09:53:22 -0300 > Arnaldo Carvalho de Melo wrote: > > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > > > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Wed, Apr 18, 2018 at 10:36:06AM -0400, Steven Rostedt escreveu: > On Wed, 18 Apr 2018 09:53:22 -0300 > Arnaldo Carvalho de Melo wrote: > > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > > > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > > > wrote: > > >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 09:53:22 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > > wrote: > > > Yeah, failing: > > > > [root@jouet ~]#

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Wed, 18 Apr 2018 09:53:22 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > > wrote: > > > Yeah, failing: > > > > [root@jouet ~]# strace -e openat -e file perf

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > wrote: > > Yeah, failing: > > [root@jouet ~]# strace -e openat -e file perf test -F -v "mmap interface" > > |& grep syscalls > > openat(AT_FDCWD,

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu: > On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo > wrote: > > Yeah, failing: > > [root@jouet ~]# strace -e openat -e file perf test -F -v "mmap interface" > > |& grep syscalls > > openat(AT_FDCWD, > >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > > Added back original compare to not miss 32bit

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > > Added back original compare to not miss 32bit kernel syscalls

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > > Added back original compare to not miss 32bit

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > > Added back original compare to not miss 32bit kernel syscalls

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > Added back original compare to not miss 32bit kernel syscalls > > > > s/32bit/32bit and 0-parameter syscalls. > > So this should have

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > Added back original compare to not miss 32bit kernel syscalls > > > > s/32bit/32bit and 0-parameter syscalls. > > So this should have

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > Added back original compare to not miss 32bit kernel syscalls > > s/32bit/32bit and 0-parameter syscalls. So this should have covered 0-parameter syscalls, ok, I'm double checking that the last patch is the one I have

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > Added back original compare to not miss 32bit kernel syscalls > > s/32bit/32bit and 0-parameter syscalls. So this should have covered 0-parameter syscalls, ok, I'm double checking that the last patch is the one I have

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 02:29:40PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 17, 2018 at 01:07:02PM -0400, Steven Rostedt escreveu: > > Because the x86 system calls had "__x64_" appended to the "sys" for the > > names, they do not match the default compare algorithm. As this was a >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 02:29:40PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 17, 2018 at 01:07:02PM -0400, Steven Rostedt escreveu: > > Because the x86 system calls had "__x64_" appended to the "sys" for the > > names, they do not match the default compare algorithm. As this was a >

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 01:07:02PM -0400, Steven Rostedt escreveu: > From: "Steven Rostedt (VMware)" > > Arnaldo noticed that the latest kernel is missing the syscall event system > directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, > syscalls/x86: Rename

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

Em Tue, Apr 17, 2018 at 01:07:02PM -0400, Steven Rostedt escreveu: > From: "Steven Rostedt (VMware)" > > Arnaldo noticed that the latest kernel is missing the syscall event system > directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, > syscalls/x86: Rename struct pt_regs-based

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

> Added back original compare to not miss 32bit kernel syscalls s/32bit/32bit and 0-parameter syscalls. Looks good otherwise. Thanks, Dominik

Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

> Added back original compare to not miss 32bit kernel syscalls s/32bit/32bit and 0-parameter syscalls. Looks good otherwise. Thanks, Dominik

[PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

From: "Steven Rostedt (VMware)" Arnaldo noticed that the latest kernel is missing the syscall event system directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()"). The system call trace

[PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

From: "Steven Rostedt (VMware)" Arnaldo noticed that the latest kernel is missing the syscall event system directory in x86. I bisected it down to d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()"). The system call trace events are special, as