Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-04-02 Thread Liu Ying
2015-03-20 19:26 GMT+08:00 Tomi Valkeinen : > On 11/03/15 05:03, Liu Ying wrote: > >>> Why do you check for host->enabled here, but not elsewhere? >> >> We need this check here to make sure the axi clock reference count is no >> greater >> than 1. Looking at the context of mxsfb_set_par(),

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-04-02 Thread Liu Ying
2015-03-20 19:26 GMT+08:00 Tomi Valkeinen tomi.valkei...@ti.com: On 11/03/15 05:03, Liu Ying wrote: Why do you check for host-enabled here, but not elsewhere? We need this check here to make sure the axi clock reference count is no greater than 1. Looking at the context of

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-20 Thread Tomi Valkeinen
On 11/03/15 05:03, Liu Ying wrote: >> Why do you check for host->enabled here, but not elsewhere? > > We need this check here to make sure the axi clock reference count is no > greater > than 1. Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and Why is that? The clock

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-20 Thread Tomi Valkeinen
On 11/03/15 05:03, Liu Ying wrote: Why do you check for host-enabled here, but not elsewhere? We need this check here to make sure the axi clock reference count is no greater than 1. Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and Why is that? The clock framework

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-10 Thread Liu Ying
On Tue, Mar 10, 2015 at 02:02:37PM +0200, Tomi Valkeinen wrote: > On 04/03/15 09:06, Liu Ying wrote: > > The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock > > as the engine's system clock. The clock should be enabled when accessing > > LCDIF registers, otherwise the kernel

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-10 Thread Tomi Valkeinen
On 04/03/15 09:06, Liu Ying wrote: > The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock > as the engine's system clock. The clock should be enabled when accessing > LCDIF registers, otherwise the kernel would hang up. We should also keep > the clock being enabled when the

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-10 Thread Tomi Valkeinen
On 04/03/15 09:06, Liu Ying wrote: The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock as the engine's system clock. The clock should be enabled when accessing LCDIF registers, otherwise the kernel would hang up. We should also keep the clock being enabled when the

Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-10 Thread Liu Ying
On Tue, Mar 10, 2015 at 02:02:37PM +0200, Tomi Valkeinen wrote: On 04/03/15 09:06, Liu Ying wrote: The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock as the engine's system clock. The clock should be enabled when accessing LCDIF registers, otherwise the kernel would

[PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-03 Thread Liu Ying
The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock as the engine's system clock. The clock should be enabled when accessing LCDIF registers, otherwise the kernel would hang up. We should also keep the clock being enabled when the engine is being active to scan out frames

[PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

2015-03-03 Thread Liu Ying
The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock as the engine's system clock. The clock should be enabled when accessing LCDIF registers, otherwise the kernel would hang up. We should also keep the clock being enabled when the engine is being active to scan out frames