Re: [PATCH v2] virtio_pmem: support feature SHMEM_REGION

2023-12-19 Thread Michael S. Tsirkin
On Tue, Dec 19, 2023 at 10:13:00PM -0800, Changyuan Lyu wrote: > On Tue, Dec 19, 2023 at 7:57 PM Jason Wang wrote: > > > > On Tue, Dec 19, 2023 at 3:19 PM Changyuan Lyu wrote: > > > > > > +/* shmid of the shared memory region corresponding to the pmem */ > > > +#define VIRTIO_PMEM_SHMCAP_ID 0 >

[PATCH v2] virtio_pmem: support feature SHMEM_REGION

2023-12-19 Thread Changyuan Lyu
On Tue, Dec 19, 2023 at 7:57 PM Jason Wang wrote: > > On Tue, Dec 19, 2023 at 3:19 PM Changyuan Lyu wrote: > > > > +/* shmid of the shared memory region corresponding to the pmem */ > > +#define VIRTIO_PMEM_SHMCAP_ID 0 > > NIT: not a native speaker, but any reason for "CAP" here? Would it be >