Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Andy Lutomirski
On Fri, Dec 1, 2017 at 8:57 AM, Boris Ostrovsky wrote: > On 12/01/2017 11:22 AM, Andy Lutomirski wrote: >> On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky >> wrote: >>> Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >>>

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Andy Lutomirski
On Fri, Dec 1, 2017 at 8:57 AM, Boris Ostrovsky wrote: > On 12/01/2017 11:22 AM, Andy Lutomirski wrote: >> On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky >> wrote: >>> Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >>> them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Boris Ostrovsky
On 12/01/2017 11:22 AM, Andy Lutomirski wrote: > On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky > wrote: >> Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >> them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses >> eflags using

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Boris Ostrovsky
On 12/01/2017 11:22 AM, Andy Lutomirski wrote: > On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky > wrote: >> Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make >> them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses >> eflags using 'pushfq' instruction when testing

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Andy Lutomirski
On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky wrote: > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make > them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses > eflags using 'pushfq' instruction when testing for IF bit. On PV Xen >

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-01 Thread Andy Lutomirski
On Tue, Nov 28, 2017 at 7:28 AM, Boris Ostrovsky wrote: > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make > them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses > eflags using 'pushfq' instruction when testing for IF bit. On PV Xen > guests looking at IF flag

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-28 Thread Juergen Gross
On 28/11/17 16:28, Boris Ostrovsky wrote: > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make > them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses > eflags using 'pushfq' instruction when testing for IF bit. On PV Xen > guests looking at IF flag directly will

Re: [PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-28 Thread Juergen Gross
On 28/11/17 16:28, Boris Ostrovsky wrote: > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make > them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses > eflags using 'pushfq' instruction when testing for IF bit. On PV Xen > guests looking at IF flag directly will

[PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-28 Thread Boris Ostrovsky
Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses eflags using 'pushfq' instruction when testing for IF bit. On PV Xen guests looking at IF flag directly will always see it set, resulting in 'ud2'. Introduce

[PATCH v2] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-11-28 Thread Boris Ostrovsky
Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses eflags using 'pushfq' instruction when testing for IF bit. On PV Xen guests looking at IF flag directly will always see it set, resulting in 'ud2'. Introduce