Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-10 Thread Sean Christopherson
On Fri, Dec 07, 2018 at 03:57:10PM -0800, Andy Lutomirski wrote: > On Fri, Dec 7, 2018 at 2:14 PM Linus Torvalds > wrote: > > > > On Fri, Dec 7, 2018 at 2:06 PM Sean Christopherson > > wrote: > > > > > > Looking at it again, my own personal preference would be to swap the order > > > of the #PF l

Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-07 Thread Andy Lutomirski
On Fri, Dec 7, 2018 at 2:14 PM Linus Torvalds wrote: > > On Fri, Dec 7, 2018 at 2:06 PM Sean Christopherson > wrote: > > > > Looking at it again, my own personal preference would be to swap the order > > of the #PF lines. > > Yeah, probably. > > Also: > > > [ 160.246820] BUG: unable to handle ke

Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-07 Thread Linus Torvalds
On Fri, Dec 7, 2018 at 2:06 PM Sean Christopherson wrote: > > Looking at it again, my own personal preference would be to swap the order > of the #PF lines. Yeah, probably. Also: > [ 160.246820] BUG: unable to handle kernel paging request at beef > [ 160.247517] #PF: supervisor-pr

Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-07 Thread Sean Christopherson
On Fri, Dec 07, 2018 at 12:46:30PM -0800, Linus Torvalds wrote: > On Fri, Dec 7, 2018 at 11:52 AM Sean Christopherson > wrote: > > > > Remove the per-bit decoding of the error code and instead print: > > The patch looks fine to me, so feel free to add an acked-by, but: > > (a) I'm not the one w

Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-07 Thread Linus Torvalds
On Fri, Dec 7, 2018 at 11:52 AM Sean Christopherson wrote: > > Remove the per-bit decoding of the error code and instead print: The patch looks fine to me, so feel free to add an acked-by, but: (a) I'm not the one who wanted the human-legible version in the first place, since I'm also perfectly

[PATCH v2] x86/fault: Decode and print #PF oops in human readable form

2018-12-07 Thread Sean Christopherson
Linus pointed out that deciphering the raw #PF error code and printing a more human readable message are two different things, and also that printing the negative cases is mostly just noise[1]. For example, the USER bit doesn't mean the fault originated in user code and stating that an oops wasn't