Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2018-01-08 Thread Baoquan He
On 01/06/18 at 02:00am, Jiri Bohac wrote: > Hi Baoquan, > > thank you very much for your review! > > On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > > > > will ignore the ram we need dump. > > > > > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2018-01-08 Thread Baoquan He
On 01/06/18 at 02:00am, Jiri Bohac wrote: > Hi Baoquan, > > thank you very much for your review! > > On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > > > > will ignore the ram we need dump. > > > > > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2018-01-05 Thread Jiri Bohac
Hi Baoquan, thank you very much for your review! On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > > > will ignore the ram we need dump. > > > > yes, instead of crashing the machine (because GART may be

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2018-01-05 Thread Jiri Bohac
Hi Baoquan, thank you very much for your review! On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > > > will ignore the ram we need dump. > > > > yes, instead of crashing the machine (because GART may be

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-27 Thread Baoquan He
On 12/27/17 at 01:25pm, Borislav Petkov wrote: > On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > yes, instead of crashing the machine (because GART may be initialized in > > > the > > > 2nd kernel, overlapping the 1st kernel memory, which the 2nd kernel with > > > its > > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-27 Thread Baoquan He
On 12/27/17 at 01:25pm, Borislav Petkov wrote: > On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > > yes, instead of crashing the machine (because GART may be initialized in > > > the > > > 2nd kernel, overlapping the 1st kernel memory, which the 2nd kernel with > > > its > > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-27 Thread Borislav Petkov
On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > yes, instead of crashing the machine (because GART may be initialized in the > > 2nd kernel, overlapping the 1st kernel memory, which the 2nd kernel with its > > fake e820 map sees as unused). > > > > I'd say this is an improvement.

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-27 Thread Borislav Petkov
On Wed, Dec 27, 2017 at 03:44:49PM +0800, Baoquan He wrote: > > yes, instead of crashing the machine (because GART may be initialized in the > > 2nd kernel, overlapping the 1st kernel memory, which the 2nd kernel with its > > fake e820 map sees as unused). > > > > I'd say this is an improvement.

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-26 Thread Baoquan He
On 12/19/17 at 06:58pm, Jiri Bohac wrote: Sorry for late response. Please see the inline comments. > > On Tue, Dec 19, 2017 at 09:58:04AM +0800, Baoquan He wrote: > > Hmm, as I have said in the first replying mail, the v2 will introduce > > issues: > > > > 1) If 'iommu=off' is specified in 1st

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-26 Thread Baoquan He
On 12/19/17 at 06:58pm, Jiri Bohac wrote: Sorry for late response. Please see the inline comments. > > On Tue, Dec 19, 2017 at 09:58:04AM +0800, Baoquan He wrote: > > Hmm, as I have said in the first replying mail, the v2 will introduce > > issues: > > > > 1) If 'iommu=off' is specified in 1st

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-19 Thread Jiri Bohac
On Tue, Dec 19, 2017 at 09:58:04AM +0800, Baoquan He wrote: > Hmm, as I have said in the first replying mail, the v2 will introduce > issues: > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > will ignore the ram we need dump. yes, instead of crashing the machine

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-19 Thread Jiri Bohac
On Tue, Dec 19, 2017 at 09:58:04AM +0800, Baoquan He wrote: > Hmm, as I have said in the first replying mail, the v2 will introduce > issues: > > 1) If 'iommu=off' is specified in 1st kernel but not in kdump kernel, it > will ignore the ram we need dump. yes, instead of crashing the machine

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Baoquan He
On 12/18/17 at 03:37pm, Borislav Petkov wrote: > On Mon, Dec 18, 2017 at 09:47:36PM +0800, Baoquan He wrote: > > pr_info("Your BIOS doesn't leave an aperture memory > > hole\n"); > > pr_info("Please enable the IOMMU option in the BIOS > > setup\n"); > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Baoquan He
On 12/18/17 at 03:37pm, Borislav Petkov wrote: > On Mon, Dec 18, 2017 at 09:47:36PM +0800, Baoquan He wrote: > > pr_info("Your BIOS doesn't leave an aperture memory > > hole\n"); > > pr_info("Please enable the IOMMU option in the BIOS > > setup\n"); > >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Borislav Petkov
On Mon, Dec 18, 2017 at 09:47:36PM +0800, Baoquan He wrote: > pr_info("Your BIOS doesn't leave an aperture memory hole\n"); > pr_info("Please enable the IOMMU option in the BIOS setup\n"); > pr_info("This costs you %dMB of RAM\n", >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Borislav Petkov
On Mon, Dec 18, 2017 at 09:47:36PM +0800, Baoquan He wrote: > pr_info("Your BIOS doesn't leave an aperture memory hole\n"); > pr_info("Please enable the IOMMU option in the BIOS setup\n"); > pr_info("This costs you %dMB of RAM\n", >

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Baoquan He
On 12/17/17 at 10:47pm, Borislav Petkov wrote: > On Sat, Dec 16, 2017 at 09:01:42AM +0800, Baoquan He wrote: > > 2) If firmware is broken, you can't enable gart in firmware, will > > firmware engineer fix this since it's a firmware bug? > > Slow down and get a reality check first please! > > A

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-18 Thread Baoquan He
On 12/17/17 at 10:47pm, Borislav Petkov wrote: > On Sat, Dec 16, 2017 at 09:01:42AM +0800, Baoquan He wrote: > > 2) If firmware is broken, you can't enable gart in firmware, will > > firmware engineer fix this since it's a firmware bug? > > Slow down and get a reality check first please! > > A

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-17 Thread Borislav Petkov
On Sat, Dec 16, 2017 at 09:01:42AM +0800, Baoquan He wrote: > 2) If firmware is broken, you can't enable gart in firmware, will > firmware engineer fix this since it's a firmware bug? Slow down and get a reality check first please! A firmware engineer will fix a 10yr old BIOS?!? Yeah right. And

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-17 Thread Borislav Petkov
On Sat, Dec 16, 2017 at 09:01:42AM +0800, Baoquan He wrote: > 2) If firmware is broken, you can't enable gart in firmware, will > firmware engineer fix this since it's a firmware bug? Slow down and get a reality check first please! A firmware engineer will fix a 10yr old BIOS?!? Yeah right. And

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-15 Thread Baoquan He
On 12/16/17 at 01:15am, Jiri Bohac wrote: > On machines where the GART aperture is mapped over physical RAM > /proc/vmcore contains the remapped range and reading it may > cause hangs or reboots. > > In the past, the GART region was added into the resource map, implemented by > commit

Re: [PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-15 Thread Baoquan He
On 12/16/17 at 01:15am, Jiri Bohac wrote: > On machines where the GART aperture is mapped over physical RAM > /proc/vmcore contains the remapped range and reading it may > cause hangs or reboots. > > In the past, the GART region was added into the resource map, implemented by > commit

[PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-15 Thread Jiri Bohac
On machines where the GART aperture is mapped over physical RAM /proc/vmcore contains the remapped range and reading it may cause hangs or reboots. In the past, the GART region was added into the resource map, implemented by commit 56dd669a138c ("[PATCH] Insert GART region into resource map")

[PATCH v2] x86/kexec: Exclude GART aperture from vmcore

2017-12-15 Thread Jiri Bohac
On machines where the GART aperture is mapped over physical RAM /proc/vmcore contains the remapped range and reading it may cause hangs or reboots. In the past, the GART region was added into the resource map, implemented by commit 56dd669a138c ("[PATCH] Insert GART region into resource map")