Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-18 Thread Steven Rostedt
On Thu, 18 Oct 2018 15:48:46 +0900 Masami Hiramatsu wrote: > On Wed, 17 Oct 2018 16:59:51 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > > function regs_get_kernel_argument() as if there's

Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-18 Thread Steven Rostedt
On Thu, 18 Oct 2018 15:48:46 +0900 Masami Hiramatsu wrote: > On Wed, 17 Oct 2018 16:59:51 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > > function regs_get_kernel_argument() as if there's

Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-18 Thread Masami Hiramatsu
On Wed, 17 Oct 2018 16:59:51 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > function regs_get_kernel_argument() as if there's any error in the stack > code, it could cause a bad memory access. To be on

Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-18 Thread Masami Hiramatsu
On Wed, 17 Oct 2018 16:59:51 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > function regs_get_kernel_argument() as if there's any error in the stack > code, it could cause a bad memory access. To be on

Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Joel Fernandes
On Wed, Oct 17, 2018 at 04:59:51PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > function regs_get_kernel_argument() as if there's any error in the stack > code, it could cause a bad memory access. To

Re: [PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Joel Fernandes
On Wed, Oct 17, 2018 at 04:59:51PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > function regs_get_kernel_argument() as if there's any error in the stack > code, it could cause a bad memory access. To

[PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Andy had some concerns about using regs_get_kernel_stack_nth() in a new function regs_get_kernel_argument() as if there's any error in the stack code, it could cause a bad memory access. To be on the safe side, call probe_kernel_read() on the stack address to be

[PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Andy had some concerns about using regs_get_kernel_stack_nth() in a new function regs_get_kernel_argument() as if there's any error in the stack code, it could cause a bad memory access. To be on the safe side, call probe_kernel_read() on the stack address to be