Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-27 Thread Jürgen Groß
On 19.01.21 11:57, Roger Pau Monne wrote: This is inline with the specification described in blkif.h: * discard-granularity: should be set to the physical block size if node is not present. * discard-alignment, discard-secure: should be set to 0 if node not present. This was

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-22 Thread Arthur Borsboom
Any chance of getting this backported to stable? I believe the previous attempt by CC-ing stable was not following the correct procedure and probably rejected. https://lkml.org/lkml/2021/1/19/543 On Wed, 20 Jan 2021 at 16:17, Arthur Borsboom wrote: > > This time the patch applied cleanly. > >

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Arthur Borsboom
This time the patch applied cleanly. The trim command seems to work as well, meaning no error messages and a certain amount of blocks (5GB) is trimmed. The trimming did consume a bit of time (10-20 seconds), assuming it is actually discarding the blocks at the host. First run: [arthur@test-arch

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 03:37:57PM +0100, Jan Beulich wrote: > On 20.01.2021 15:35, Roger Pau Monné wrote: > > On Wed, Jan 20, 2021 at 03:23:30PM +0100, Arthur Borsboom wrote: > >> Hi Roger, > >> > >> I have set up a test environment based on Linux 5.11.0-rc4. > >> The patch did not apply clean,

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Arthur Borsboom
Hi Roger, I have set up a test environment based on Linux 5.11.0-rc4. The patch did not apply clean, so I copied/pasted the patch manually. Without the patch the call trace (as reported) is visible in dmesg. With the patch the call trace in dmesg is gone, but ... (there is always a but) ... Now

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Jan Beulich
On 20.01.2021 15:35, Roger Pau Monné wrote: > On Wed, Jan 20, 2021 at 03:23:30PM +0100, Arthur Borsboom wrote: >> Hi Roger, >> >> I have set up a test environment based on Linux 5.11.0-rc4. >> The patch did not apply clean, so I copied/pasted the patch manually. >> >> Without the patch the call

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Roger Pau Monné
Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Mon, 18 Jan 2021 11:47:05 +0100 Subject: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is inline with the specification described in blkif.

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 01:36:22PM +0100, Roger Pau Monné wrote: > Forgot to Cc stable for the Fixes tag. Doing it now. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Roger Pau Monné
Forgot to Cc stable for the Fixes tag. Doing it now. On Tue, Jan 19, 2021 at 11:57:27AM +0100, Roger Pau Monne wrote: > This is inline with the specification described in blkif.h: > > * discard-granularity: should be set to the physical block size if >node is not present. > *

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Jürgen Groß
On 19.01.21 11:57, Roger Pau Monne wrote: This is inline with the specification described in blkif.h: * discard-granularity: should be set to the physical block size if node is not present. * discard-alignment, discard-secure: should be set to 0 if node not present. This was

[PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Roger Pau Monne
This is inline with the specification described in blkif.h: * discard-granularity: should be set to the physical block size if node is not present. * discard-alignment, discard-secure: should be set to 0 if node not present. This was detected as QEMU would only create the