Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-17 Thread Hiraku Toyooka
(12/15/2012 02:08 AM), Steven Rostedt wrote: On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] > > Actually, I would have: > > status\input | 0 | 1 |else| >

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-17 Thread Hiraku Toyooka
(12/15/2012 02:08 AM), Steven Rostedt wrote: On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] Actually, I would have: status\input | 0 | 1 |else|

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-14 Thread Steven Rostedt
On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: > Hi, Steven, > > (2012/11/30 23:17), Steven Rostedt wrote: > [snip] > > > > Actually, I would have: > > > > status\input | 0 | 1 |else| > > --++++ > > not

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-14 Thread Steven Rostedt
On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] Actually, I would have: status\input | 0 | 1 |else| --++++ not allocated |(do

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-07 Thread Steven Rostedt
On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: > Hi, Steven, > > (2012/11/30 23:17), Steven Rostedt wrote: > [snip] > > > > Actually, I would have: > > > > status\input | 0 | 1 |else| > > --++++ > > not

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-07 Thread Steven Rostedt
On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] Actually, I would have: status\input | 0 | 1 |else| --++++ not allocated |(do

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-06 Thread Hiraku Toyooka
Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] > > Actually, I would have: > > status\input | 0 | 1 |else| > --++++ > not allocated |(do nothing)| alloc+swap | EINVAL | >

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-06 Thread Hiraku Toyooka
Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] Actually, I would have: status\input | 0 | 1 |else| --++++ not allocated |(do nothing)| alloc+swap | EINVAL |

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-30 Thread Steven Rostedt
On Fri, 2012-11-30 at 14:46 +0900, Hiraku Toyooka wrote: > Hi, Steven, > > Thank you for your review. > > (2012/11/16 10:46), Steven Rostedt wrote: > [snip] > > I was thinking about this some more, and I don't like the > > snapshot_allocate part. Also, I think the snapshot should not be > >

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-30 Thread Steven Rostedt
On Fri, 2012-11-30 at 14:46 +0900, Hiraku Toyooka wrote: Hi, Steven, Thank you for your review. (2012/11/16 10:46), Steven Rostedt wrote: [snip] I was thinking about this some more, and I don't like the snapshot_allocate part. Also, I think the snapshot should not be allocated by

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-29 Thread Hiraku Toyooka
Hi, Steven, Thank you for your review. (2012/11/16 10:46), Steven Rostedt wrote: [snip] > I was thinking about this some more, and I don't like the > snapshot_allocate part. Also, I think the snapshot should not be > allocated by default, and not used until the user explicitly asks for > it. >

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-29 Thread Hiraku Toyooka
Hi, Steven, Thank you for your review. (2012/11/16 10:46), Steven Rostedt wrote: [snip] I was thinking about this some more, and I don't like the snapshot_allocate part. Also, I think the snapshot should not be allocated by default, and not used until the user explicitly asks for it. Have

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-15 Thread Steven Rostedt
On Wed, 2012-10-17 at 11:56 +0900, Hiraku Toyooka wrote: > Ftrace has a snapshot feature available from kernel space and > latency tracers (e.g. irqsoff) are using it. This patch enables > user applictions to take a snapshot via debugfs. > > Add following two debugfs files in "tracing" directory.

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-15 Thread Steven Rostedt
On Wed, 2012-10-17 at 11:56 +0900, Hiraku Toyooka wrote: Ftrace has a snapshot feature available from kernel space and latency tracers (e.g. irqsoff) are using it. This patch enables user applictions to take a snapshot via debugfs. Add following two debugfs files in tracing directory.

[PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-10-16 Thread Hiraku Toyooka
Ftrace has a snapshot feature available from kernel space and latency tracers (e.g. irqsoff) are using it. This patch enables user applictions to take a snapshot via debugfs. Add following two debugfs files in "tracing" directory. snapshot: This is used to take a snapshot and to read the

[PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-10-16 Thread Hiraku Toyooka
Ftrace has a snapshot feature available from kernel space and latency tracers (e.g. irqsoff) are using it. This patch enables user applictions to take a snapshot via debugfs. Add following two debugfs files in tracing directory. snapshot: This is used to take a snapshot and to read the