Re: [PATCH v2 0/1] add (un)patch callbacks

2017-08-15 Thread Miroslav Benes
On Tue, 8 Aug 2017, Joe Lawrence wrote:

> Hi folks,
> 
> This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.
> 
> The documentation is still a little rough, but I wanted to post up the
> code for feedback before getting too far in revising it.
> 
> This implements the pre and post handlers as Josh suggested.  See
> summary of related changes below...
> 
> v2:
> - s/hooks/callbacks/g
> - implemented pre-(un)patch and post-(un)patch callbacks
>   - pre-patch and pre-unpatch callbacks run from callers of
> klp_patch_object() and klp_unpatch_object()
>   - post-patch and post-unpatch callbacks run from
> klp_complete_transition() and klp_module_coming/going()
> - reduce callbacks from a list to a single per-klp_object instance
> - revamp the sample callback demo
> - revamp documentation
> 
> Feedback appreciated as always.

Looks almost good to me. v3 with Josh's review should be ok.

Miroslav


Re: [PATCH v2 0/1] add (un)patch callbacks

2017-08-15 Thread Miroslav Benes
On Tue, 8 Aug 2017, Joe Lawrence wrote:

> Hi folks,
> 
> This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.
> 
> The documentation is still a little rough, but I wanted to post up the
> code for feedback before getting too far in revising it.
> 
> This implements the pre and post handlers as Josh suggested.  See
> summary of related changes below...
> 
> v2:
> - s/hooks/callbacks/g
> - implemented pre-(un)patch and post-(un)patch callbacks
>   - pre-patch and pre-unpatch callbacks run from callers of
> klp_patch_object() and klp_unpatch_object()
>   - post-patch and post-unpatch callbacks run from
> klp_complete_transition() and klp_module_coming/going()
> - reduce callbacks from a list to a single per-klp_object instance
> - revamp the sample callback demo
> - revamp documentation
> 
> Feedback appreciated as always.

Looks almost good to me. v3 with Josh's review should be ok.

Miroslav


[PATCH v2 0/1] add (un)patch callbacks

2017-08-08 Thread Joe Lawrence
Hi folks,

This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.

The documentation is still a little rough, but I wanted to post up the
code for feedback before getting too far in revising it.

This implements the pre and post handlers as Josh suggested.  See
summary of related changes below...

v2:
- s/hooks/callbacks/g
- implemented pre-(un)patch and post-(un)patch callbacks
  - pre-patch and pre-unpatch callbacks run from callers of
klp_patch_object() and klp_unpatch_object()
  - post-patch and post-unpatch callbacks run from
klp_complete_transition() and klp_module_coming/going()
- reduce callbacks from a list to a single per-klp_object instance
- revamp the sample callback demo
- revamp documentation

Feedback appreciated as always.

Joe Lawrence (1):
  livepatch: add (un)patch callbacks

 Documentation/livepatch/callbacks.txt|  75 +++
 include/linux/livepatch.h|  38 ++
 kernel/livepatch/core.c  |  30 -
 kernel/livepatch/patch.c |   5 +-
 kernel/livepatch/transition.c|  19 ++-
 samples/livepatch/Makefile   |   2 +
 samples/livepatch/livepatch-callbacks-demo.c | 180 +++
 samples/livepatch/livepatch-callbacks-mod.c  |  53 
 8 files changed, 393 insertions(+), 9 deletions(-)
 create mode 100644 Documentation/livepatch/callbacks.txt
 create mode 100644 samples/livepatch/livepatch-callbacks-demo.c
 create mode 100644 samples/livepatch/livepatch-callbacks-mod.c

-- 
1.8.3.1



[PATCH v2 0/1] add (un)patch callbacks

2017-08-08 Thread Joe Lawrence
Hi folks,

This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.

The documentation is still a little rough, but I wanted to post up the
code for feedback before getting too far in revising it.

This implements the pre and post handlers as Josh suggested.  See
summary of related changes below...

v2:
- s/hooks/callbacks/g
- implemented pre-(un)patch and post-(un)patch callbacks
  - pre-patch and pre-unpatch callbacks run from callers of
klp_patch_object() and klp_unpatch_object()
  - post-patch and post-unpatch callbacks run from
klp_complete_transition() and klp_module_coming/going()
- reduce callbacks from a list to a single per-klp_object instance
- revamp the sample callback demo
- revamp documentation

Feedback appreciated as always.

Joe Lawrence (1):
  livepatch: add (un)patch callbacks

 Documentation/livepatch/callbacks.txt|  75 +++
 include/linux/livepatch.h|  38 ++
 kernel/livepatch/core.c  |  30 -
 kernel/livepatch/patch.c |   5 +-
 kernel/livepatch/transition.c|  19 ++-
 samples/livepatch/Makefile   |   2 +
 samples/livepatch/livepatch-callbacks-demo.c | 180 +++
 samples/livepatch/livepatch-callbacks-mod.c  |  53 
 8 files changed, 393 insertions(+), 9 deletions(-)
 create mode 100644 Documentation/livepatch/callbacks.txt
 create mode 100644 samples/livepatch/livepatch-callbacks-demo.c
 create mode 100644 samples/livepatch/livepatch-callbacks-mod.c

-- 
1.8.3.1