Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-16 Thread Rob Clark
On Thu, Oct 8, 2020 at 1:24 AM Ville Syrjälä wrote: > > On Wed, Oct 07, 2020 at 09:44:09AM -0700, Rob Clark wrote: > > On Mon, Oct 5, 2020 at 5:15 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > > > On Fri, Oct 2, 2020 at 4:05 AM Ville

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-08 Thread Daniel Vetter
On Wed, Oct 07, 2020 at 05:30:10PM +0100, Qais Yousef wrote: > On 10/07/20 08:57, Rob Clark wrote: > > Yeah, I think we will end up making some use of uclamp.. there is > > someone else working on that angle > > > > But without it, this is a case that exposes legit prioritization > > problems

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-08 Thread Ville Syrjälä
On Wed, Oct 07, 2020 at 09:44:09AM -0700, Rob Clark wrote: > On Mon, Oct 5, 2020 at 5:15 AM Ville Syrjälä > wrote: > > > > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Rob Clark
On Mon, Oct 5, 2020 at 5:15 AM Ville Syrjälä wrote: > > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > > > On Thu, Oct 01, 2020 at 05:25:55PM

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Qais Yousef
On 10/07/20 08:57, Rob Clark wrote: > Yeah, I think we will end up making some use of uclamp.. there is > someone else working on that angle > > But without it, this is a case that exposes legit prioritization > problems with commit_work which we should fix ;-) I wasn't suggesting this as an

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Rob Clark
On Wed, Oct 7, 2020 at 3:36 AM Qais Yousef wrote: > > On 10/06/20 13:04, Rob Clark wrote: > > On Tue, Oct 6, 2020 at 3:59 AM Qais Yousef wrote: > > > > > > On 10/05/20 16:24, Rob Clark wrote: > > > > > > [...] > > > > > > > > RT planning and partitioning is not easy task for sure. You might > >

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Qais Yousef
On 10/06/20 13:04, Rob Clark wrote: > On Tue, Oct 6, 2020 at 3:59 AM Qais Yousef wrote: > > > > On 10/05/20 16:24, Rob Clark wrote: > > > > [...] > > > > > > RT planning and partitioning is not easy task for sure. You might want > > > > to > > > > consider using affinities too to get stronger

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-06 Thread Rob Clark
On Tue, Oct 6, 2020 at 3:59 AM Qais Yousef wrote: > > On 10/05/20 16:24, Rob Clark wrote: > > [...] > > > > RT planning and partitioning is not easy task for sure. You might want to > > > consider using affinities too to get stronger guarantees for some tasks > > > and > > > prevent

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-06 Thread Qais Yousef
On 10/05/20 16:24, Rob Clark wrote: [...] > > RT planning and partitioning is not easy task for sure. You might want to > > consider using affinities too to get stronger guarantees for some tasks and > > prevent cross-talking. > > There is some cgroup stuff that is pinning SF and some other

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-06 Thread Peter Zijlstra
On Tue, Oct 06, 2020 at 11:08:59AM +0200, Daniel Vetter wrote: > vblank work needs to preempt commit work. > > Right now we don't have any driver requiring this, but if we e.g. roll out > the gamma table update for i915, then this _has_ to happen in the vblank > period. > > Whereas the commit

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-06 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 04:24:38PM -0700, Rob Clark wrote: > On Mon, Oct 5, 2020 at 8:00 AM Qais Yousef wrote: > > > > +CC Steve and Peter - they might be interested. > > > > On 10/02/20 11:07, Rob Clark wrote: > > > On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > > > > > > > On 09/30/20

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 8:00 AM Qais Yousef wrote: > > +CC Steve and Peter - they might be interested. > > On 10/02/20 11:07, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > > > > > On 09/30/20 14:17, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > The android

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 7:15 AM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 03:15:24PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Qais Yousef
+CC Steve and Peter - they might be interested. On 10/02/20 11:07, Rob Clark wrote: > On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > > > On 09/30/20 14:17, Rob Clark wrote: > > > From: Rob Clark > > > > > > The android userspace treats the display pipeline as a realtime problem. > > >

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 03:15:24PM +0300, Ville Syrjälä wrote: > On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > > > On Thu, Oct 01, 2020 at

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-05 Thread Ville Syrjälä
On Fri, Oct 02, 2020 at 10:55:52AM -0700, Rob Clark wrote: > On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä > wrote: > > > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > > > > On Thu, Oct 1, 2020 at 5:15 PM Rob

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > On 09/30/20 14:17, Rob Clark wrote: > > From: Rob Clark > > > > The android userspace treats the display pipeline as a realtime problem. > > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > > it is. (See

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 4:05 AM Ville Syrjälä wrote: > > On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > > > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Ville Syrjälä
On Fri, Oct 02, 2020 at 01:52:56PM +0300, Ville Syrjälä wrote: > On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > > > > > > > On Wed, Sep 30, 2020 at 11:16 PM

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Qais Yousef
On 09/30/20 14:17, Rob Clark wrote: > From: Rob Clark > > The android userspace treats the display pipeline as a realtime problem. > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > it is. (See https://lwn.net/Articles/809545/ for the best explaination > that I found.)

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-02 Thread Ville Syrjälä
On Thu, Oct 01, 2020 at 05:25:55PM +0200, Daniel Vetter wrote: > On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > > > On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > > > > > On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > > > > > > > From: Rob Clark > > > > > > > > The

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-01 Thread Daniel Vetter
On Thu, Oct 1, 2020 at 5:15 PM Rob Clark wrote: > > On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > > > On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > The android userspace treats the display pipeline as a realtime problem. > > > And

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-01 Thread Rob Clark
On Thu, Oct 1, 2020 at 12:25 AM Daniel Vetter wrote: > > On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > > > From: Rob Clark > > > > The android userspace treats the display pipeline as a realtime problem. > > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > > it

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-01 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 11:16 PM Rob Clark wrote: > > From: Rob Clark > > The android userspace treats the display pipeline as a realtime problem. > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > it is. (See https://lwn.net/Articles/809545/ for the best explaination >

[PATCH v2 0/3] drm: commit_work scheduling

2020-09-30 Thread Rob Clark
From: Rob Clark The android userspace treats the display pipeline as a realtime problem. And arguably, if your goal is to not miss frame deadlines (ie. vblank), it is. (See https://lwn.net/Articles/809545/ for the best explaination that I found.) But this presents a problem with using