Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-07-09 Thread Petr Mladek
On Wed 2018-06-27 16:08:14, Petr Mladek wrote: > The commit 719f6a7040f1bdaf96 ("printk: Use the main logbuf in NMI > when logbuf_lock is available") brought back the possible deadlocks > in printk() and NMI. > > This is rework of the proposed fix, see > https://lkml.kernel.org/r/20180606111557.xz

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-28 Thread Sergey Senozhatsky
On (06/28/18 12:54), Petr Mladek wrote: > > On Thu 2018-06-28 11:39:02, Sergey Senozhatsky wrote: > > On (06/27/18 16:08), Petr Mladek wrote: > > > > > > kernel/printk/printk.c | 57 > > > +++- > > > kernel/printk/printk_safe.c | 58 > > > +++

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-28 Thread Petr Mladek
On Thu 2018-06-28 11:39:02, Sergey Senozhatsky wrote: > On (06/27/18 16:08), Petr Mladek wrote: > > > > kernel/printk/printk.c | 57 > > +++- > > kernel/printk/printk_safe.c | 58 > > + > > Shall we just me

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-28 Thread Sergey Senozhatsky
On (06/27/18 16:34), Petr Mladek wrote: [..] > > > Changes against v1: > > > > > > + Move the check from vprintk_emit() to vprintk_func() > > > + More straightforward commit message > > > + Fix build with CONFIG_PRINTK_NMI disabled > > > > Did I miss out V1? > > It is the above fixed link.

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-27 Thread Sergey Senozhatsky
On (06/27/18 16:08), Petr Mladek wrote: > > kernel/printk/printk.c | 57 +++- > kernel/printk/printk_safe.c | 58 > + Shall we just merge these two? -ss

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-27 Thread Petr Mladek
On Wed 2018-06-27 23:16:12, Sergey Senozhatsky wrote: > On (06/27/18 16:08), Petr Mladek wrote: > > The commit 719f6a7040f1bdaf96 ("printk: Use the main logbuf in NMI > > when logbuf_lock is available") brought back the possible deadlocks > > in printk() and NMI. > > > > This is rework of the prop

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-27 Thread Sergey Senozhatsky
On (06/27/18 23:16), Sergey Senozhatsky wrote: > > Petr Mladek (3): > > printk: Split the code for storing a message into the log buffer > > printk: Create helper function to queue deferred console handling > > printk/nmi: Prevent deadlock when accessing the main log buffer in NMI > > Patch

Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-27 Thread Sergey Senozhatsky
On (06/27/18 16:08), Petr Mladek wrote: > The commit 719f6a7040f1bdaf96 ("printk: Use the main logbuf in NMI > when logbuf_lock is available") brought back the possible deadlocks > in printk() and NMI. > > This is rework of the proposed fix, see > https://lkml.kernel.org/r/20180606111557.xzs6l3lkv

[PATCH v2 0/3] printk: Deadlock in NMI regression

2018-06-27 Thread Petr Mladek
The commit 719f6a7040f1bdaf96 ("printk: Use the main logbuf in NMI when logbuf_lock is available") brought back the possible deadlocks in printk() and NMI. This is rework of the proposed fix, see https://lkml.kernel.org/r/20180606111557.xzs6l3lkvg7lq...@pathway.suse.cz I realized that we could ra