Re: [PATCH v2 0/4] Add online file check feature

2015-12-06 Thread Gang He
Hello Greg and Pavel, Sorry, there was a misunderstand, I was not aware that there were some design constraints for sysfs interfaces. I will review and modify this portion code. Thanks Gang >>> > On Fri, Dec 04, 2015 at 01:36:21AM -0700, Gang He wrote: >> Hi Greg, >> >> >> >>> >> > On

Re: [PATCH v2 0/4] Add online file check feature

2015-12-06 Thread Gang He
Hello Greg and Pavel, Sorry, there was a misunderstand, I was not aware that there were some design constraints for sysfs interfaces. I will review and modify this portion code. Thanks Gang >>> > On Fri, Dec 04, 2015 at 01:36:21AM -0700, Gang He wrote: >> Hi Greg, >> >> >> >>> >> > On

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Greg KH
On Fri, Dec 04, 2015 at 01:36:21AM -0700, Gang He wrote: > Hi Greg, > > > >>> > > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > >> Hello Pavel, > >> > >> > >> > >> >>> > >> > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> >> When there are errors in the ocfs2 filesystem, > >>

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Pavel Machek
On Fri 2015-12-04 01:36:21, Gang He wrote: > Hi Greg, > > > >>> > > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > >> Hello Pavel, > >> > >> > >> > >> >>> > >> > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> >> When there are errors in the ocfs2 filesystem, > >> >> they are

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Gang He
Hi Greg, >>> > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: >> Hello Pavel, >> >> >> >> >>> >> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> >> When there are errors in the ocfs2 filesystem, >> >> they are usually accompanied by the inode number which caused the error. >> >>

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Gang He
Hi Greg, >>> > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: >> Hello Pavel, >> >> >> >> >>> >> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> >> When there are errors in the ocfs2 filesystem, >> >> they are usually accompanied by the inode number which caused the error. >> >>

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Pavel Machek
On Fri 2015-12-04 01:36:21, Gang He wrote: > Hi Greg, > > > >>> > > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > >> Hello Pavel, > >> > >> > >> > >> >>> > >> > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> >> When there are errors in the ocfs2 filesystem, > >> >> they are

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Greg KH
On Fri, Dec 04, 2015 at 01:36:21AM -0700, Gang He wrote: > Hi Greg, > > > >>> > > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > >> Hello Pavel, > >> > >> > >> > >> >>> > >> > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> >> When there are errors in the ocfs2 filesystem, > >>

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Greg KH
On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > Hello Pavel, > > > > >>> > > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> When there are errors in the ocfs2 filesystem, > >> they are usually accompanied by the inode number which caused the error. > >> This inode number would be

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Gang He
Hello Pavel, >>> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by the inode number which caused the error. >> This inode number would be the input to fixing the file. >> One of these options could be considered:

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Pavel Machek
On Wed 2015-10-28 14:25:57, Gang He wrote: > When there are errors in the ocfs2 filesystem, > they are usually accompanied by the inode number which caused the error. > This inode number would be the input to fixing the file. > One of these options could be considered: > A file in the sys

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Pavel Machek
On Wed 2015-10-28 14:25:57, Gang He wrote: > When there are errors in the ocfs2 filesystem, > they are usually accompanied by the inode number which caused the error. > This inode number would be the input to fixing the file. > One of these options could be considered: > A file in the sys

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Greg KH
On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: > Hello Pavel, > > > > >>> > > On Wed 2015-10-28 14:25:57, Gang He wrote: > >> When there are errors in the ocfs2 filesystem, > >> they are usually accompanied by the inode number which caused the error. > >> This inode number would be

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Gang He
Hello Pavel, >>> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by the inode number which caused the error. >> This inode number would be the input to fixing the file. >> One of these options could be considered:

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Gang He
Hello Srini, The real cases are that we try to fix some independent issues without turning the file system off-line (error=continue was introduced). You know, the online file check feature is used for fixing some independent or light meta-data block corruption, e.g. inode block, file extent

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Srinivas Eeda
Hi Gang, thanks for pointing to explanation of the feature. What I am curious about is ... what were the real cases that you came across prompted this change and how this change would help in that case. Thanks, --Srini On 10/28/2015 09:44 PM, Gang He wrote: Hello Srini, There is a doc

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Srinivas Eeda
Hi Gang, thanks for pointing to explanation of the feature. What I am curious about is ... what were the real cases that you came across prompted this change and how this change would help in that case. Thanks, --Srini On 10/28/2015 09:44 PM, Gang He wrote: Hello Srini, There is a doc

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Gang He
Hello Srini, The real cases are that we try to fix some independent issues without turning the file system off-line (error=continue was introduced). You know, the online file check feature is used for fixing some independent or light meta-data block corruption, e.g. inode block, file extent

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Gang He
Hello Srini, There is a doc about ocfs2 online file check. OCFS2 online file check --- This document will describe OCFS2 online file check feature. Introduction OCFS2 is often used in high-availaibility systems. However, OCFS2 usually converts the filesystem to

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Srinivas Eeda
Hi Gang, thank you for implementing this. I would like to understand this better on where and how it helps ... would you mind sharing couple examples(real scenarios). Thanks, --Srini On 10/27/2015 11:25 PM, Gang He wrote: When there are errors in the ocfs2 filesystem, they are usually

[PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Gang He
When there are errors in the ocfs2 filesystem, they are usually accompanied by the inode number which caused the error. This inode number would be the input to fixing the file. One of these options could be considered: A file in the sys filesytem which would accept inode numbers. This could be

[PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Gang He
When there are errors in the ocfs2 filesystem, they are usually accompanied by the inode number which caused the error. This inode number would be the input to fixing the file. One of these options could be considered: A file in the sys filesytem which would accept inode numbers. This could be

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Srinivas Eeda
Hi Gang, thank you for implementing this. I would like to understand this better on where and how it helps ... would you mind sharing couple examples(real scenarios). Thanks, --Srini On 10/27/2015 11:25 PM, Gang He wrote: When there are errors in the ocfs2 filesystem, they are usually

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Gang He
Hello Srini, There is a doc about ocfs2 online file check. OCFS2 online file check --- This document will describe OCFS2 online file check feature. Introduction OCFS2 is often used in high-availaibility systems. However, OCFS2 usually converts the filesystem to