Andrew Morton writes:
> On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes
> wrote:
>
>> Minor comment: Won't this end up saying "list_sort_test: list passed to
>> ...", despite the list coming from a 'real' user? Maybe change the first
>> #define to '"list_sort: " fmt', the above message to
On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes
wrote:
> > We may as well do the pr_foo() conversion as well. As often happens,
> > the results are quite pleasing.
> >
> > --- a/lib/list_sort.c~lib-list_sortc-convert-to-pr_foo
> > +++ a/lib/list_sort.c
> > @@ -1,3 +1,6 @@
> > +
> >
Andrew Morton writes:
> On Tue, 24 Jun 2014 12:06:27 +0200 Rasmus Villemoes
> wrote:
>
>> Reading the source of lib/list_sort.c, I came up with a few possible
>> improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
>> 3/4 should be straightforward.
>>
>
> All looks OK to me.
On Tue, 24 Jun 2014 12:06:27 +0200 Rasmus Villemoes
wrote:
> Reading the source of lib/list_sort.c, I came up with a few possible
> improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
> 3/4 should be straightforward.
>
All looks OK to me.
We may as well do the pr_foo()
On Tue, 24 Jun 2014 12:06:27 +0200 Rasmus Villemoes li...@rasmusvillemoes.dk
wrote:
Reading the source of lib/list_sort.c, I came up with a few possible
improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
3/4 should be straightforward.
All looks OK to me.
We may as well
Andrew Morton a...@linux-foundation.org writes:
On Tue, 24 Jun 2014 12:06:27 +0200 Rasmus Villemoes
li...@rasmusvillemoes.dk wrote:
Reading the source of lib/list_sort.c, I came up with a few possible
improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
3/4 should be
On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes li...@rasmusvillemoes.dk
wrote:
We may as well do the pr_foo() conversion as well. As often happens,
the results are quite pleasing.
--- a/lib/list_sort.c~lib-list_sortc-convert-to-pr_foo
+++ a/lib/list_sort.c
@@ -1,3 +1,6 @@
+
Andrew Morton a...@linux-foundation.org writes:
On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes
li...@rasmusvillemoes.dk wrote:
Minor comment: Won't this end up saying list_sort_test: list passed to
..., despite the list coming from a 'real' user? Maybe change the first
#define to
Reading the source of lib/list_sort.c, I came up with a few possible
improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
3/4 should be straightforward.
v2: Fix typo in 2/4, and add 3/4,4/4.
Rasmus Villemoes (4):
lib: list_sort_test(): Return -ENOMEM when allocation fails
Reading the source of lib/list_sort.c, I came up with a few possible
improvements. I think 4/4 may be a bit controversial, but 1/4, 2/4 and
3/4 should be straightforward.
v2: Fix typo in 2/4, and add 3/4,4/4.
Rasmus Villemoes (4):
lib: list_sort_test(): Return -ENOMEM when allocation fails
10 matches
Mail list logo
