Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-15 Thread Pratyush Yadav
Hi Mason, On 15/05/20 10:26AM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > > > > I can't apply your patches to enable xSPI Octal mode for > > > > > mx25uw51245g because your patches set up Octal protocol first and > > > > > then using Octal protocol to write Configuration Register

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-14 Thread masonccyang
Hi Pratyush, > > > > I can't apply your patches to enable xSPI Octal mode for > > > > mx25uw51245g because your patches set up Octal protocol first and > > > > then using Octal protocol to write Configuration Register 2(CFG > > > > Reg2). I think driver > > > > should write CFG Reg2 in SPI

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-11 Thread masonccyang
Hi Boris, > > > > > > > > To clarify a bit more, the idea is that we transmit the opcode MSB > > > > first, just we do for the address. Assume we want to issue the command > > > > 0x05. In 1S mode, we set cmd.opcode to 0x05. Here cmd.nbytes == 1. Treat > > > > > > > is as a 1-byte

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-10 Thread masonccyang
Hi Vignesh, > >>> > >>> Our mx25uw51245g supports BFPT DWORD-18,19 and 20 data and xSPI > > profile > >>> 1.0, > >>> and it comply with BFPT DWORD-19, octal mode enable sequences by write > > CFG > >>> Reg2 > >>> with instruction 0x72. Therefore, I can't apply your patches. > >> > >> I

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-06 Thread Pratyush Yadav
On 05/05/20 05:31PM, masonccy...@mxic.com.tw wrote: > Hi Pratyush, > > > I can't apply your patches to enable xSPI Octal mode for > > > mx25uw51245g because your patches set up Octal protocol first and > > > then using Octal protocol to write Configuration Register 2(CFG > > > Reg2). I think

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-05 Thread Boris Brezillon
On Tue, 5 May 2020 11:44:43 +0200 Boris Brezillon wrote: > On Tue, 5 May 2020 17:31:45 +0800 > masonccy...@mxic.com.tw wrote: > > > > > > > > I quickly went through your patches but can't reply them in each > > > > > > > > your > > > > > > patches. > > > > > > > > > > > > i.e,. > > >

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-05 Thread Boris Brezillon
On Tue, 5 May 2020 17:31:45 +0800 masonccy...@mxic.com.tw wrote: > > > > > I quickly went through your patches but can't reply them in each > your > > > > > patches. > > > > > > > > > > i.e,. > > > > > 1) [v4,03/16] spi: spi-mem: allow specifying a command's extension > > > > > > > > > > -

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-05-05 Thread masonccyang
Hi Pratyush, > > > > > > > > > > I posted a re-roll of my series here [0]. Could you please base your > > > > > > > changes on top of it? Let me know if the series is missing something > > you > > > > > > > > > need. > > > > > > > > > > [0] > > > > > >

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-30 Thread Vignesh Raghavendra
Hi Mason, On 29/04/20 1:01 pm, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > On Tue, 21 Apr 2020 14:39:42 +0800 > Mason Yang wrote: [...] >>> > https://lore.kernel.org/linux-mtd/20200424184410.8578-1-p.ya...@ti.com/ >>> >>> >>> Our mx25uw51245g supports BFPT DWORD-18,19 and

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-29 Thread Pratyush Yadav
Hi Mason, On 29/04/20 03:31PM, masonccy...@mxic.com.tw wrote: > Hi Pratyush, > > > > Hi Mason, > > > > > > > > I posted a re-roll of my series here [0]. Could you please base your > > > > > changes on top of it? Let me know if the series is missing something > you > > > > > > > need. > > >

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-29 Thread Boris Brezillon
On Wed, 29 Apr 2020 15:31:35 +0800 masonccy...@mxic.com.tw wrote: > Hi Pratyush, > > > > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > > > > Mason Yang wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > This is repost of patchset from Boris Brezillon's > > > > > > [RFC,00/18] mtd:

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-29 Thread masonccyang
Hi Pratyush, > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > > > Mason Yang wrote: > > > > > > > > > Hello, > > > > > > > > > > This is repost of patchset from Boris Brezillon's > > > > > [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode support [1]. > > > > > > > > I only quickly went

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-29 Thread masonccyang
Hi Boris, > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > > > Mason Yang wrote: > > > > > > > > > Hello, > > > > > > > > > > This is repost of patchset from Boris Brezillon's > > > > > [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode support [1]. > > > > > > > > I only quickly went through

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-28 Thread Pratyush Yadav
Hi Mason, On 28/04/20 02:14PM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > > Mason Yang wrote: > > > > > > > Hello, > > > > > > > > This is repost of patchset from Boris Brezillon's > > > > [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode

Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode

2020-04-28 Thread Pratyush Yadav
On 28/04/20 08:34AM, Boris Brezillon wrote: > On Tue, 28 Apr 2020 14:14:31 +0800 > masonccy...@mxic.com.tw wrote: > > > > I quickly went through your patches but can't reply them in each > > your patches. > > Why?!! Aren't you registered to the MTD mailing list? Sorry but having > reviews