Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Fri, Apr 9, 2021 at 9:58 AM Jonathan Neuschäfer wrote: > On Fri, Apr 09, 2021 at 04:37:34AM +, Joel Stanley wrote: > > On Tue, 6 Apr 2021 at 21:59, Jonathan Neuschäfer > > wrote: > > I've had a look at the series and it looks good to me: > > > > Reviewed-by: Joel Stanley > > > > Nice work Jonathan. > > > > I'll put this in it's own branch along with the bindings change it > > depends on and send a pull request to Arnd for v5.13. > > Thanks a bunch! > > A few patches are going through other branches (IRQ bindings+driver; > watchdog bindings+driver probably, I guess). That leaves the following > patches to go into your branch, AFAIUI: > > [PATCH v2 01/10] dt-bindings: vendor-prefixes: Add Supermicro > [PATCH v2 02/10] dt-bindings: arm: npcm: Add nuvoton,wpcm450 compatible string > [PATCH v2 05/10] ARM: npcm: Introduce Nuvoton WPCM450 SoC > [PATCH v2 08/10] ARM: dts: Add devicetree for Nuvoton WPCM450 BMC chip > [PATCH v2 09/10] ARM: dts: Add devicetree for Supermicro X9SCi-LN4F based on > WPCM450 > [PATCH v2 10/10] MAINTAINERS: Add entry for Nuvoton WPCM450 Actually for an initial merge, we sometimes just put all the patches into one branch in the soc tree to avoid conflicts. Unfortunately we already have a (trivial) conflict now anyway since I merged the irqchip driver for the Apple M1 SoC through the soc tree but the wpcm irqchip through the irqchip tree. You did nothing wrong here, this would have just been a way to make the initial merge a bit easier, and have a tree that is more easily bisectible when one branch in the merge window contains all the code that is needed for booting. Arnd
Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Fri, Apr 09, 2021 at 04:37:34AM +, Joel Stanley wrote: > On Tue, 6 Apr 2021 at 21:59, Jonathan Neuschäfer > wrote: > > > > On Tue, Apr 06, 2021 at 05:15:01PM +0200, Arnd Bergmann wrote: > > > On Tue, Apr 6, 2021 at 2:09 PM Jonathan Neuschäfer > > > wrote: > > > > > > > > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an > > > > older > > > > SoC but still commonly found on eBay, mostly in Supermicro X9 server > > > > boards. > > > > > > > > Third-party documentation is available at: > > > > https://github.com/neuschaefer/wpcm450/wiki > > > > > > > > Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various > > > > parts. > > > > Patches 5-7 add arch and driver support. Patches 8 and 9 add a > > > > devicetree for > > > > the SoC and a board based on it. Patch 10 finally updates the > > > > MAINTAINERS file. > > > > > > > > Patch 2 requires "dt-bindings: arm: Convert nuvoton,npcm750 binding to > > > > YAML" > > > > (https://lore.kernel.org/lkml/20210320164023.614059-1-j.neuschae...@gmx.net/) > > > > > > Hi Jonathan, > > > > > > It appears these patches are doing roughly the right thing, and we may > > > still > > > be able to get them into v5.13, but I'm not sure what your plan for > > > maintaining > > > them is. The two options are that you either send your patches to be > > > picked up > > > by Joel, or you send everything directly to s...@kernel.org once it's > > > fully > > > reviewed. > > > > The route via Joel sounds alright with me. I've Cc'd him on this version > > of the series. > > I've had a look at the series and it looks good to me: > > Reviewed-by: Joel Stanley > > Nice work Jonathan. > > I'll put this in it's own branch along with the bindings change it > depends on and send a pull request to Arnd for v5.13. Thanks a bunch! A few patches are going through other branches (IRQ bindings+driver; watchdog bindings+driver probably, I guess). That leaves the following patches to go into your branch, AFAIUI: [PATCH v2 01/10] dt-bindings: vendor-prefixes: Add Supermicro [PATCH v2 02/10] dt-bindings: arm: npcm: Add nuvoton,wpcm450 compatible string [PATCH v2 05/10] ARM: npcm: Introduce Nuvoton WPCM450 SoC [PATCH v2 08/10] ARM: dts: Add devicetree for Nuvoton WPCM450 BMC chip [PATCH v2 09/10] ARM: dts: Add devicetree for Supermicro X9SCi-LN4F based on WPCM450 [PATCH v2 10/10] MAINTAINERS: Add entry for Nuvoton WPCM450 Jonathan signature.asc Description: PGP signature
Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Tue, 6 Apr 2021 at 21:59, Jonathan Neuschäfer wrote: > > On Tue, Apr 06, 2021 at 05:15:01PM +0200, Arnd Bergmann wrote: > > On Tue, Apr 6, 2021 at 2:09 PM Jonathan Neuschäfer > > wrote: > > > > > > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an > > > older > > > SoC but still commonly found on eBay, mostly in Supermicro X9 server > > > boards. > > > > > > Third-party documentation is available at: > > > https://github.com/neuschaefer/wpcm450/wiki > > > > > > Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various > > > parts. > > > Patches 5-7 add arch and driver support. Patches 8 and 9 add a devicetree > > > for > > > the SoC and a board based on it. Patch 10 finally updates the MAINTAINERS > > > file. > > > > > > Patch 2 requires "dt-bindings: arm: Convert nuvoton,npcm750 binding to > > > YAML" > > > (https://lore.kernel.org/lkml/20210320164023.614059-1-j.neuschae...@gmx.net/) > > > > Hi Jonathan, > > > > It appears these patches are doing roughly the right thing, and we may still > > be able to get them into v5.13, but I'm not sure what your plan for > > maintaining > > them is. The two options are that you either send your patches to be picked > > up > > by Joel, or you send everything directly to s...@kernel.org once it's fully > > reviewed. > > The route via Joel sounds alright with me. I've Cc'd him on this version > of the series. I've had a look at the series and it looks good to me: Reviewed-by: Joel Stanley Nice work Jonathan. I'll put this in it's own branch along with the bindings change it depends on and send a pull request to Arnd for v5.13. Cheers, Joel
Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Tue, 6 Apr 2021 14:09:11 +0200, Jonathan Neuschäfer wrote: > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an older > SoC but still commonly found on eBay, mostly in Supermicro X9 server boards. > > Third-party documentation is available at: > https://github.com/neuschaefer/wpcm450/wiki > > Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various parts. > Patches 5-7 add arch and driver support. Patches 8 and 9 add a devicetree for > the SoC and a board based on it. Patch 10 finally updates the MAINTAINERS > file. > > [...] Applied to irq/irqchip-next, thanks! [03/10] dt-bindings: interrupt-controller: Add nuvoton, wpcm450-aic commit: 7c18715546203a09f859dac2fe3ea8aceec5f235 [06/10] irqchip: Add driver for WPCM450 interrupt controller commit: fead4dd496631707549f414b4059afb86ea8fb80 Cheers, M. -- Without deviation from the norm, progress is not possible.
Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Tue, Apr 06, 2021 at 05:15:01PM +0200, Arnd Bergmann wrote: > On Tue, Apr 6, 2021 at 2:09 PM Jonathan Neuschäfer > wrote: > > > > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an > > older > > SoC but still commonly found on eBay, mostly in Supermicro X9 server boards. > > > > Third-party documentation is available at: > > https://github.com/neuschaefer/wpcm450/wiki > > > > Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various > > parts. > > Patches 5-7 add arch and driver support. Patches 8 and 9 add a devicetree > > for > > the SoC and a board based on it. Patch 10 finally updates the MAINTAINERS > > file. > > > > Patch 2 requires "dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML" > > (https://lore.kernel.org/lkml/20210320164023.614059-1-j.neuschae...@gmx.net/) > > Hi Jonathan, > > It appears these patches are doing roughly the right thing, and we may still > be able to get them into v5.13, but I'm not sure what your plan for > maintaining > them is. The two options are that you either send your patches to be picked up > by Joel, or you send everything directly to s...@kernel.org once it's fully > reviewed. The route via Joel sounds alright with me. I've Cc'd him on this version of the series. > I only noticed your series when patch 9/10 made it into the s...@kernel.org > patchwork because of the Cc, but none of the other ones did. > > If you end up with the second option, we can go through what this involves > off-list. > > Regarding the Cc:s...@kernel.org, please add that only for patches that > are already reviewed and ready to be picked up, ideally with a cover letter > that describes what the plan is for merging. If you need me to review the > platform code, use my a...@arndb.de or a...@kernel.org addresses. Ah sorry, s...@kernel.org slipped in automatically because of get_maintainers.pl. The platform code[1] is rather simple, essentially just hooking up the nuvoton,wpcm450 compatible string. Thanks, Jonathan [1]: https://lore.kernel.org/lkml/20210406120921.2484986-6-j.neuschae...@gmx.net/ signature.asc Description: PGP signature
Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
On Tue, Apr 6, 2021 at 2:09 PM Jonathan Neuschäfer wrote: > > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an older > SoC but still commonly found on eBay, mostly in Supermicro X9 server boards. > > Third-party documentation is available at: > https://github.com/neuschaefer/wpcm450/wiki > > Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various parts. > Patches 5-7 add arch and driver support. Patches 8 and 9 add a devicetree for > the SoC and a board based on it. Patch 10 finally updates the MAINTAINERS > file. > > Patch 2 requires "dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML" > (https://lore.kernel.org/lkml/20210320164023.614059-1-j.neuschae...@gmx.net/) Hi Jonathan, It appears these patches are doing roughly the right thing, and we may still be able to get them into v5.13, but I'm not sure what your plan for maintaining them is. The two options are that you either send your patches to be picked up by Joel, or you send everything directly to s...@kernel.org once it's fully reviewed. I only noticed your series when patch 9/10 made it into the s...@kernel.org patchwork because of the Cc, but none of the other ones did. If you end up with the second option, we can go through what this involves off-list. Regarding the Cc:s...@kernel.org, please add that only for patches that are already reviewed and ready to be picked up, ideally with a cover letter that describes what the plan is for merging. If you need me to review the platform code, use my a...@arndb.de or a...@kernel.org addresses. Arnd
[PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC
This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an older SoC but still commonly found on eBay, mostly in Supermicro X9 server boards. Third-party documentation is available at: https://github.com/neuschaefer/wpcm450/wiki Patches 1-4 add devicetree bindings for the WPCM450 SoC and its various parts. Patches 5-7 add arch and driver support. Patches 8 and 9 add a devicetree for the SoC and a board based on it. Patch 10 finally updates the MAINTAINERS file. Patch 2 requires "dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML" (https://lore.kernel.org/lkml/20210320164023.614059-1-j.neuschae...@gmx.net/) v2: - Various improvements to the AIC irqchip driver, thanks to Marc Zyngier's review - I dropped the timer patches, which have been applied by Daniel Lezcano - I dropped the serial patches, which have been applied to tty-next by Greg KH v1: - https://lore.kernel.org/lkml/20210320181610.680870-1-j.neuschae...@gmx.net/ Jonathan Neuschäfer (10): dt-bindings: vendor-prefixes: Add Supermicro dt-bindings: arm: npcm: Add nuvoton,wpcm450 compatible string dt-bindings: interrupt-controller: Add nuvoton,wpcm450-aic dt-bindings: watchdog: npcm: Add nuvoton,wpcm450-wdt ARM: npcm: Introduce Nuvoton WPCM450 SoC irqchip: Add driver for WPCM450 interrupt controller watchdog: npcm: Add support for WPCM450 ARM: dts: Add devicetree for Nuvoton WPCM450 BMC chip ARM: dts: Add devicetree for Supermicro X9SCi-LN4F based on WPCM450 MAINTAINERS: Add entry for Nuvoton WPCM450 .../devicetree/bindings/arm/npcm/npcm.yaml| 6 + .../nuvoton,wpcm450-aic.yaml | 39 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + .../bindings/watchdog/nuvoton,npcm-wdt.txt| 3 +- MAINTAINERS | 9 + arch/arm/boot/dts/Makefile| 2 + .../nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 40 + arch/arm/boot/dts/nuvoton-wpcm450.dtsi| 76 + arch/arm/mach-npcm/Kconfig| 13 +- arch/arm/mach-npcm/Makefile | 1 + arch/arm/mach-npcm/wpcm450.c | 13 ++ drivers/irqchip/Kconfig | 6 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-wpcm450-aic.c | 161 ++ drivers/watchdog/npcm_wdt.c | 1 + 15 files changed, 371 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml create mode 100644 arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts create mode 100644 arch/arm/boot/dts/nuvoton-wpcm450.dtsi create mode 100644 arch/arm/mach-npcm/wpcm450.c create mode 100644 drivers/irqchip/irq-wpcm450-aic.c -- 2.30.2
