Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:34, Christoph Hellwig 님이 작성: > > On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote: > > I think that PageHighMemZone() is long and complicated enough to have > > a macro. > > It is. But then again it also shouldn't really be used by anything > but MM internals. I'm

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-01 Thread Christoph Hellwig
On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote: > I think that PageHighMemZone() is long and complicated enough to have > a macro. It is. But then again it also shouldn't really be used by anything but MM internals. > > PageHighMemZone(page) =

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-01 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 7:55, Christoph Hellwig 님이 작성: > > On Fri, May 01, 2020 at 07:52:35PM +0900, Joonsoo Kim wrote: > > > - New code will pop up which gets it wrong and nobody will notice for > > > a long time. > > > > Hmm... I think that it's not that hard to decide correct macro. If we rename >

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-01 Thread Christoph Hellwig
On Fri, May 01, 2020 at 07:52:35PM +0900, Joonsoo Kim wrote: > > - New code will pop up which gets it wrong and nobody will notice for > > a long time. > > Hmm... I think that it's not that hard to decide correct macro. If we rename > PageHighMem() with PageDirectMapped(), they,

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-01 Thread Joonsoo Kim
2020년 4월 30일 (목) 오전 10:47, Andrew Morton 님이 작성: > > On Wed, 29 Apr 2020 12:26:33 +0900 js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > Changes on v2 > > - add "acked-by", "reviewed-by" tags > > - replace PageHighMem() with use open-code, instead of using > > new PageHighMemZone() macro.

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-04-29 Thread Andrew Morton
On Wed, 29 Apr 2020 12:26:33 +0900 js1...@gmail.com wrote: > From: Joonsoo Kim > > Changes on v2 > - add "acked-by", "reviewed-by" tags > - replace PageHighMem() with use open-code, instead of using > new PageHighMemZone() macro. Related file is "include/linux/migrate.h" > > Hello, > > This

[PATCH v2 00/10] change the implementation of the PageHighMem()

2020-04-28 Thread js1304
From: Joonsoo Kim Changes on v2 - add "acked-by", "reviewed-by" tags - replace PageHighMem() with use open-code, instead of using new PageHighMemZone() macro. Related file is "include/linux/migrate.h" Hello, This patchset separates two use cases of PageHighMem() by introducing