Re: [PATCH v2 01/10] dt-bindings: clock: Add syscon support to Actions Semi Owl SoCs
On Wed, Aug 01, 2018 at 09:09:06AM +0530, Manivannan Sadhasivam wrote: > Since the clock and reset management units are sharing the same memory > map, document the clock bindings to support System Controller. This is no reason to add child nodes. The existing node can be both a clock and reset provider. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/clock/actions,owl-cmu.txt| 21 +-- > 1 file changed, 15 insertions(+), 6 deletions(-)
Re: [PATCH v2 01/10] dt-bindings: clock: Add syscon support to Actions Semi Owl SoCs
On Wed, Aug 01, 2018 at 09:09:06AM +0530, Manivannan Sadhasivam wrote: > Since the clock and reset management units are sharing the same memory > map, document the clock bindings to support System Controller. This is no reason to add child nodes. The existing node can be both a clock and reset provider. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/clock/actions,owl-cmu.txt| 21 +-- > 1 file changed, 15 insertions(+), 6 deletions(-)
[PATCH v2 01/10] dt-bindings: clock: Add syscon support to Actions Semi Owl SoCs
Since the clock and reset management units are sharing the same memory
map, document the clock bindings to support System Controller.
Signed-off-by: Manivannan Sadhasivam
---
.../bindings/clock/actions,owl-cmu.txt| 21 +--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
index d1e60d297387..649c95fc4582 100644
--- a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
+++ b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
@@ -9,8 +9,6 @@ Required Properties:
- compatible: should be one of the following,
"actions,s900-cmu"
"actions,s700-cmu"
-- reg: physical base address of the controller and length of memory mapped
- region.
- clocks: Reference to the parent clocks ("hosc", "losc")
- #clock-cells: should be 1.
@@ -21,6 +19,13 @@ All available clocks are defined as preprocessor macros in
corresponding
dt-bindings/clock/actions,s900-cmu.h or actions,s700-cmu.h header and can be
used in device tree sources.
+The CMU registers are part of the system-controller block on Owl SoCs.
+
+Parent node should have the following properties :
+- compatible: "syscon", "simple-mfd"
+- reg: physical base address of the controller and length of memory mapped
+ region.
+
External clocks:
The hosc clock used as input for the plls is generated outside the SoC. It is
@@ -31,11 +36,15 @@ Actions Semi S900 CMU also requires one more clock:
Example: Clock Management Unit node:
-cmu: clock-controller@e016 {
-compatible = "actions,s900-cmu";
+sysctrl: system-controller@e016 {
+compatible = "syscon", "simple-mfd";
reg = <0x0 0xe016 0x0 0x1000>;
-clocks = <>, <>;
-#clock-cells = <1>;
+
+cmu: clock-controller {
+compatible = "actions,s900-cmu";
+clocks = <>, <>;
+#clock-cells = <1>;
+};
};
Example: UART controller node that consumes clock generated by the clock
--
2.17.1
[PATCH v2 01/10] dt-bindings: clock: Add syscon support to Actions Semi Owl SoCs
Since the clock and reset management units are sharing the same memory
map, document the clock bindings to support System Controller.
Signed-off-by: Manivannan Sadhasivam
---
.../bindings/clock/actions,owl-cmu.txt| 21 +--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
index d1e60d297387..649c95fc4582 100644
--- a/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
+++ b/Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
@@ -9,8 +9,6 @@ Required Properties:
- compatible: should be one of the following,
"actions,s900-cmu"
"actions,s700-cmu"
-- reg: physical base address of the controller and length of memory mapped
- region.
- clocks: Reference to the parent clocks ("hosc", "losc")
- #clock-cells: should be 1.
@@ -21,6 +19,13 @@ All available clocks are defined as preprocessor macros in
corresponding
dt-bindings/clock/actions,s900-cmu.h or actions,s700-cmu.h header and can be
used in device tree sources.
+The CMU registers are part of the system-controller block on Owl SoCs.
+
+Parent node should have the following properties :
+- compatible: "syscon", "simple-mfd"
+- reg: physical base address of the controller and length of memory mapped
+ region.
+
External clocks:
The hosc clock used as input for the plls is generated outside the SoC. It is
@@ -31,11 +36,15 @@ Actions Semi S900 CMU also requires one more clock:
Example: Clock Management Unit node:
-cmu: clock-controller@e016 {
-compatible = "actions,s900-cmu";
+sysctrl: system-controller@e016 {
+compatible = "syscon", "simple-mfd";
reg = <0x0 0xe016 0x0 0x1000>;
-clocks = <>, <>;
-#clock-cells = <1>;
+
+cmu: clock-controller {
+compatible = "actions,s900-cmu";
+clocks = <>, <>;
+#clock-cells = <1>;
+};
};
Example: UART controller node that consumes clock generated by the clock
--
2.17.1
