Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Robin, On 01/17/2018 08:18 PM, Robin Murphy wrote: @@ -91,7 +92,6 @@ struct rk_iommu { void __iomem **bases; int num_mmu; int *irq; Nit: irq seems to be redundant now as well. oops, will fix it. -int num_irq; bool reset_disabled; struct iommu_device

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Robin, On 01/17/2018 08:18 PM, Robin Murphy wrote: @@ -91,7 +92,6 @@ struct rk_iommu { void __iomem **bases; int num_mmu; int *irq; Nit: irq seems to be redundant now as well. oops, will fix it. -int num_irq; bool reset_disabled; struct iommu_device

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On 16/01/18 13:25, Jeffy Chen wrote: Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-)

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On 16/01/18 13:25, Jeffy Chen wrote: Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Tomasz, On 01/17/2018 03:16 PM, Tomasz Figa wrote: >> >>This lacks consistency. of_irq_count() is used for counting, but >>platform_get_irq() is used for getting. Either platform_ or of_ API >>should be used for both and I'd lean for platform_, since it's more >>general. > >hmmm, right, i

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Tomasz, On 01/17/2018 03:16 PM, Tomasz Figa wrote: >> >>This lacks consistency. of_irq_count() is used for counting, but >>platform_get_irq() is used for getting. Either platform_ or of_ API >>should be used for both and I'd lean for platform_, since it's more >>general. > >hmmm, right, i

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On Wed, Jan 17, 2018 at 4:08 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 12:21 PM, Tomasz Figa wrote: >> >> Hi Jeffy, >> >> Thanks for the patch. Please see my comments inline. >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

On Wed, Jan 17, 2018 at 4:08 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > On 01/17/2018 12:21 PM, Tomasz Figa wrote: >> >> Hi Jeffy, >> >> Thanks for the patch. Please see my comments inline. >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >> >> Please add patch

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Jeffy, Thanks for the patch. Please see my comments inline. On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: Please add patch description. > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > --- [snip]

Re: [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Hi Jeffy, Thanks for the patch. Please see my comments inline. On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: Please add patch description. > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > --- [snip] > - for (i = 0; i < iommu->num_irq; i++) { > -

[PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git

[PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe()

Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index