Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-19 Thread Tejun Heo
On Fri, Oct 19, 2012 at 01:34:21PM -0700, Tejun Heo wrote: > On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: > > This adds a pointer to the bvec array to struct bio_integrity_payload, > > instead of the bvecs always being inline; then the bvecs are allocated > > with

Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-19 Thread Tejun Heo
On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: > This adds a pointer to the bvec array to struct bio_integrity_payload, > instead of the bvecs always being inline; then the bvecs are allocated > with bvec_alloc_bs(). > > This is needed eventually for immutable bio vecs -

Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-19 Thread Tejun Heo
On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable

Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-19 Thread Tejun Heo
On Fri, Oct 19, 2012 at 01:34:21PM -0700, Tejun Heo wrote: On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs().

[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-15 Thread Kent Overstreet
This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable bvecs aren't useful if we still have to copy them, hence the need for

[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-10-15 Thread Kent Overstreet
This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable bvecs aren't useful if we still have to copy them, hence the need for

Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-20 Thread Tejun Heo
Hello, On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: > This adds a pointer to the bvec array to struct bio_integrity_payload, > instead of the bvecs always being inline; then the bvecs are allocated > with bvec_alloc_bs(). > > This is needed eventually for immutable bio vecs -

Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-20 Thread Tejun Heo
Hello, On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs -

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-17 Thread Kent Overstreet
On Wed, Sep 12, 2012 at 03:39:18PM -0400, Martin K. Petersen wrote: > > "Kent" == Kent Overstreet writes: > > Kent, > > Kent> To fix the bug first, I'd have to reorder struct bio_pair and then > Kent> just delete two lines of code from bio_integrity_split(). But the > Kent> reordering is

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-17 Thread Kent Overstreet
On Wed, Sep 12, 2012 at 03:39:18PM -0400, Martin K. Petersen wrote: Kent == Kent Overstreet koverstr...@google.com writes: Kent, Kent To fix the bug first, I'd have to reorder struct bio_pair and then Kent just delete two lines of code from bio_integrity_split(). But the Kent reordering

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-12 Thread Martin K. Petersen
> "Kent" == Kent Overstreet writes: Kent, Kent> To fix the bug first, I'd have to reorder struct bio_pair and then Kent> just delete two lines of code from bio_integrity_split(). But the Kent> reordering is unnecessary with the refactoring. Well, a bug is a bug and the fix needs to go into

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-12 Thread Martin K. Petersen
Kent == Kent Overstreet koverstr...@google.com writes: Kent, Kent To fix the bug first, I'd have to reorder struct bio_pair and then Kent just delete two lines of code from bio_integrity_split(). But the Kent reordering is unnecessary with the refactoring. Well, a bug is a bug and the fix

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Kent Overstreet
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote: > Also there seems to be too much happening in this patch. Please break > it down in 2. First fix the bio integrity bug you mentioned then > introduce your changes on top. Oh, I forgot - the reason I squashed them into one patch is

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Kent Overstreet
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote: > On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: > > This adds a pointer to the bvec array to struct bio_integrity_payload, > > instead of the bvecs always being inline; then the bvecs are allocated > > with

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Vivek Goyal
On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: > This adds a pointer to the bvec array to struct bio_integrity_payload, > instead of the bvecs always being inline; then the bvecs are allocated > with bvec_alloc_bs(). If you starting allocating bvec from same mempool for bio and

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Vivek Goyal
On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). If you starting allocating bvec from same mempool for bio and

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Kent Overstreet
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote: On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote: This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs().

Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-11 Thread Kent Overstreet
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote: Also there seems to be too much happening in this patch. Please break it down in 2. First fix the bio integrity bug you mentioned then introduce your changes on top. Oh, I forgot - the reason I squashed them into one patch is fixing

[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-10 Thread Kent Overstreet
This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable bvecs aren't useful if we still have to copy them, hence the need for

[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-10 Thread Kent Overstreet
This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable bvecs aren't useful if we still have to copy them, hence the need for