Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-03 Thread Greg KH
On Sat, Apr 03, 2021 at 09:48:06AM +0200, Fabio Aiuto wrote: > On Sat, Apr 03, 2021 at 09:40:08AM +0200, Greg KH wrote: > > On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > > > remove all RT_TRACE logs > > > > > > > I don't mean to be a pain, but this changelog text needs some

Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-03 Thread Fabio Aiuto
On Sat, Apr 03, 2021 at 09:40:08AM +0200, Greg KH wrote: > On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > > remove all RT_TRACE logs > > > > I don't mean to be a pain, but this changelog text needs some work. > > This says _what_ it does, but not _why_ you are doing this. The

Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-03 Thread Greg KH
On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > remove all RT_TRACE logs > I don't mean to be a pain, but this changelog text needs some work. This says _what_ it does, but not _why_ you are doing this. The kernel documentation has a section on how to write a good changelog

[PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 82 ++- 1 file changed, 7 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index