Re: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The idea behind devres is that the release callbacks are called if > probe fails. As we now check the return value of ixgbe_mii_bus_init(), > we can drop the call devm_mdiobus_free() in error path as the release

[PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()

2020-06-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The idea behind devres is that the release callbacks are called if probe fails. As we now check the return value of ixgbe_mii_bus_init(), we can drop the call devm_mdiobus_free() in error path as the release callback will be called automatically. Signed-off-by: Bartosz

RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()

2020-06-29 Thread Kirsher, Jeffrey T
elli ; Russell King > ; Rob Herring ; Frank Rowand > > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-media...@lists.infradead.org; > devicet...@vger.kernel.org; Bartosz Golaszewski > > Subject: [PATCH v2 02/10] net: