Re: [PATCH v2 04/12] i2c: designware: Convert driver to using regmap API

2020-05-20 Thread Serge Semin
On Wed, May 20, 2020 at 03:16:07PM +0300, Jarkko Nikula wrote: > On 5/10/20 12:50 PM, Serge Semin wrote: > > Seeing the DW I2C driver is using flags-based accessors with two > > conditional clauses it would be better to replace them with the regmap > > API IO methods and to initialize the regmap

Re: [PATCH v2 04/12] i2c: designware: Convert driver to using regmap API

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map

[PATCH v2 04/12] i2c: designware: Convert driver to using regmap API

2020-05-10 Thread Serge Semin
Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map implementation. This will be also handy for