From: Rafael J. Wysocki
> Sent: 01 April 2021 14:50
...
> So what exactly is wrong with using "packed"? It is way easier to
> understand for a casual reader of the code.
Because it is usually wrong!
If I have:
struct foo {
u64 val;
} __packed;
And then have:
u64
On Thu, Apr 1, 2021 at 11:00 AM David Laight wrote:
>
> From: Bjorn Helgaas
> > Sent: 31 March 2021 18:22
> >
> > On Wed, Mar 31, 2021 at 11:55:08PM +0800, Zhang Rui wrote:
> > > ...
> >
> > > From e18c942855e2f51e814d057fff4dd951cd0d0907 Mon Sep 17 00:00:00 2001
> > > From: Zhang Rui
> > >
On Thu, Apr 1, 2021 at 4:23 PM David Laight wrote:
>
> From: Rafael J. Wysocki
> > Sent: 01 April 2021 14:50
> ...
> > So what exactly is wrong with using "packed"? It is way easier to
> > understand for a casual reader of the code.
>
> Because it is usually wrong!
>
> If I have:
>
From: Bjorn Helgaas
> Sent: 31 March 2021 18:22
>
> On Wed, Mar 31, 2021 at 11:55:08PM +0800, Zhang Rui wrote:
> > ...
>
> > From e18c942855e2f51e814d057fff4dd951cd0d0907 Mon Sep 17 00:00:00 2001
> > From: Zhang Rui
> > Date: Wed, 31 Mar 2021 20:34:13 +0800
> > Subject: [PATCH] ACPI: tables:
On Wed, Mar 31, 2021 at 11:55:08PM +0800, Zhang Rui wrote:
> ...
> From e18c942855e2f51e814d057fff4dd951cd0d0907 Mon Sep 17 00:00:00 2001
> From: Zhang Rui
> Date: Wed, 31 Mar 2021 20:34:13 +0800
> Subject: [PATCH] ACPI: tables: FPDT: Fix 64bit alignment issue
>
> Some of the 64bit items in
From: Zhang Rui
> Sent: 31 March 2021 16:55
> On Tue, 2021-03-30 at 08:14 +, David Laight wrote:
> > From: Zhang Rui
> > > Sent: 30 March 2021 09:00
> > > > On Tue, 2021-03-30 at 10:23 +0800, Xiaofei Tan wrote:
> > > > > Hi David,
> > > > >
> > > > > On 2021/3/29 18:09, David Laight wrote:
> >
ernel.org; linux-kernel@vger.kernel.org;
> > linux-...@vger.kernel.org;
> > linux...@openeuler.org
> > Subject: Re: [PATCH v2 04/15] ACPI: table: replace
> > __attribute__((packed)) by __packed
> >
> > On Tue, 2021-03-30 at 15:31 +0800, Zhang Rui wrote:
&
x-kernel@vger.kernel.org;
> > linux-...@vger.kernel.org;
> > linux...@openeuler.org
> > Subject: Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed))
> > by __packed
> >
> > On Tue, 2021-03-30 at 15:31 +0800, Zhang Rui wrote:
> > > On Tue, 2021-03-30 at
From: Zhang Rui
> Sent: 30 March 2021 09:00
> To: Xiaofei Tan ; David Laight
> ; r...@rjwysocki.net;
> l...@kernel.org; bhelg...@google.com
> Cc: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-...@vger.kernel.org;
> linux...@openeuler.org
> Subject: R
On Tue, 2021-03-30 at 15:31 +0800, Zhang Rui wrote:
> On Tue, 2021-03-30 at 10:23 +0800, Xiaofei Tan wrote:
> > Hi David,
> >
> > On 2021/3/29 18:09, David Laight wrote:
> > > From: Xiaofei Tan
> > > > Sent: 27 March 2021 07:46
> > > >
> > > > Replace __attribute__((packed)) by __packed
On Tue, 2021-03-30 at 10:23 +0800, Xiaofei Tan wrote:
> Hi David,
>
> On 2021/3/29 18:09, David Laight wrote:
> > From: Xiaofei Tan
> > > Sent: 27 March 2021 07:46
> > >
> > > Replace __attribute__((packed)) by __packed following the
> > > advice of checkpatch.pl.
> > >
> > > Signed-off-by:
Hi David,
On 2021/3/29 18:09, David Laight wrote:
From: Xiaofei Tan
Sent: 27 March 2021 07:46
Replace __attribute__((packed)) by __packed following the
advice of checkpatch.pl.
Signed-off-by: Xiaofei Tan
---
drivers/acpi/acpi_fpdt.c | 6 +++---
1 file changed, 3 insertions(+), 3
From: Xiaofei Tan
> Sent: 27 March 2021 07:46
>
> Replace __attribute__((packed)) by __packed following the
> advice of checkpatch.pl.
>
> Signed-off-by: Xiaofei Tan
> ---
> drivers/acpi/acpi_fpdt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
Replace __attribute__((packed)) by __packed following the
advice of checkpatch.pl.
Signed-off-by: Xiaofei Tan
---
drivers/acpi/acpi_fpdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
index a89a806..690a88a 100644
14 matches
Mail list logo
