Re: [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-22 Thread Jerome Brunet
On Tue, 2017-08-22 at 13:08 +0200, Ulf Hansson wrote: > On 21 August 2017 at 18:02, Jerome Brunet wrote: > > spinlock used in interrupt handler should use the _irqsave variant > > Exactly why is that needed? That's a mistake left over from a debugging session. Thx for

Re: [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-22 Thread Jerome Brunet
On Tue, 2017-08-22 at 13:08 +0200, Ulf Hansson wrote: > On 21 August 2017 at 18:02, Jerome Brunet wrote: > > spinlock used in interrupt handler should use the _irqsave variant > > Exactly why is that needed? That's a mistake left over from a debugging session. Thx for pointing it out. I'll

Re: [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-22 Thread Ulf Hansson
On 21 August 2017 at 18:02, Jerome Brunet wrote: > spinlock used in interrupt handler should use the _irqsave variant Exactly why is that needed? > > Fixes: 51c5d8447bd7 ("MMC: meson: initial support for GX platforms") > Reviewed-by: Kevin Hilman >

Re: [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-22 Thread Ulf Hansson
On 21 August 2017 at 18:02, Jerome Brunet wrote: > spinlock used in interrupt handler should use the _irqsave variant Exactly why is that needed? > > Fixes: 51c5d8447bd7 ("MMC: meson: initial support for GX platforms") > Reviewed-by: Kevin Hilman > Signed-off-by: Jerome Brunet > --- >

[PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-21 Thread Jerome Brunet
spinlock used in interrupt handler should use the _irqsave variant Fixes: 51c5d8447bd7 ("MMC: meson: initial support for GX platforms") Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 5 +++-- 1 file

[PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock

2017-08-21 Thread Jerome Brunet
spinlock used in interrupt handler should use the _irqsave variant Fixes: 51c5d8447bd7 ("MMC: meson: initial support for GX platforms") Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet --- drivers/mmc/host/meson-gx-mmc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff