Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2].
Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: Borislav Petkov <b...@alien8.de> Cc: <x...@kernel.org> Cc: Jiri Olsa <jo...@kernel.org> Cc: Alexei Starovoitov <a...@kernel.org> Cc: Jessica Yu <j...@kernel.org> Cc: Evan Green <evgr...@chromium.org> Cc: Hsin-Yi Wang <hsi...@chromium.org> Cc: Petr Mladek <pmla...@suse.com> Cc: Steven Rostedt <rost...@goodmis.org> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Cc: Matthew Wilcox <wi...@infradead.org> Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd <swb...@chromium.org> --- arch/x86/kernel/dumpstack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 299c20f0a38b..7ad5eea99b2b 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -143,9 +143,9 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl) void show_ip(struct pt_regs *regs, const char *loglvl) { #ifdef CONFIG_X86_32 - printk("%sEIP: %pS\n", loglvl, (void *)regs->ip); + printk("%sEIP: %pSb\n", loglvl, (void *)regs->ip); #else - printk("%sRIP: %04x:%pS\n", loglvl, (int)regs->cs, (void *)regs->ip); + printk("%sRIP: %04x:%pSb\n", loglvl, (int)regs->cs, (void *)regs->ip); #endif show_opcodes(regs, loglvl); } -- https://chromeos.dev
