RE: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Yang, Wenyou
Hi Sylvain, > -Original Message- > From: Sylvain Rochet [mailto:sylvain.roc...@finsecur.com] > Sent: Monday, January 26, 2015 6:10 PM > To: Yang, Wenyou > Cc: Ferre, Nicolas; li...@arm.linux.org.uk; > linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org;

Re: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Sylvain Rochet
Hello Wenyou, On Mon, Jan 26, 2015 at 05:42:11PM +0800, Wenyou Yang wrote: > +static int at91_pm_verify_clocks(suspend_state_t state) > { > unsigned long scsr; > int i; > > + /* For PM_SUSPEND_STANDBY, skip verifying the clock */ > + if (state == PM_SUSPEND_STANDBY) > +

[PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Wenyou Yang
To simply the PM code, the suspend to standby mode uses the same sram function as the suspend to memory mode, running in the internal SRAM, instead of the respective code for each mode. But for the suspend to standby mode, the master clock doesn't switch to the slow clock, and the main

RE: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Yang, Wenyou
Hi Sylvain, -Original Message- From: Sylvain Rochet [mailto:sylvain.roc...@finsecur.com] Sent: Monday, January 26, 2015 6:10 PM To: Yang, Wenyou Cc: Ferre, Nicolas; li...@arm.linux.org.uk; linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org;

Re: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Sylvain Rochet
Hello Wenyou, On Mon, Jan 26, 2015 at 05:42:11PM +0800, Wenyou Yang wrote: +static int at91_pm_verify_clocks(suspend_state_t state) { unsigned long scsr; int i; + /* For PM_SUSPEND_STANDBY, skip verifying the clock */ + if (state == PM_SUSPEND_STANDBY) +

[PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Wenyou Yang
To simply the PM code, the suspend to standby mode uses the same sram function as the suspend to memory mode, running in the internal SRAM, instead of the respective code for each mode. But for the suspend to standby mode, the master clock doesn't switch to the slow clock, and the main