Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

2016-02-09 Thread Michał Kępień
> > > > An SMBIOS buffer pointer does not need to be returned by > > > > dell_smbios_send_request(), because SMBIOS call results are stored in > > > > the buffer passed as input. > In my tree, I reworded this as: > > dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request() >

Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

2016-02-09 Thread Darren Hart
On Tue, Feb 09, 2016 at 02:27:36PM +0100, Michał Kępień wrote: > > > An SMBIOS buffer pointer does not need to be returned by > > > dell_smbios_send_request(), because SMBIOS call results are stored in > > > the buffer passed as input. > > > > This should come before 6/16, update the commit messag

Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

2016-02-09 Thread Michał Kępień
> > An SMBIOS buffer pointer does not need to be returned by > > dell_smbios_send_request(), because SMBIOS call results are stored in > > the buffer passed as input. > > This should come before 6/16, update the commit message to reflect the module > exported buffer (not the one passed as input),

Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

2016-02-08 Thread Darren Hart
On Fri, Jan 22, 2016 at 03:27:19PM +0100, Michał Kępień wrote: > An SMBIOS buffer pointer does not need to be returned by > dell_smbios_send_request(), because SMBIOS call results are stored in > the buffer passed as input. This should come before 6/16, update the commit message to reflect the mod

[PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

2016-01-22 Thread Michał Kępień
An SMBIOS buffer pointer does not need to be returned by dell_smbios_send_request(), because SMBIOS call results are stored in the buffer passed as input. Signed-off-by: Michał Kępień --- drivers/platform/x86/dell-smbios.c |5 + drivers/platform/x86/dell-smbios.h |3 +-- 2 files chan