Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-27 Thread Quentin Perret
On Thursday 26 Jul 2018 at 17:39:19 (-0700), Joel Fernandes wrote: > On Tue, Jul 24, 2018 at 06:29:02AM -0700, Tejun Heo wrote: > > Hello, Patrick. > > > > On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > > > However, the "best effort" bandwidth control we have for CFS and RT >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-27 Thread Quentin Perret
On Thursday 26 Jul 2018 at 17:39:19 (-0700), Joel Fernandes wrote: > On Tue, Jul 24, 2018 at 06:29:02AM -0700, Tejun Heo wrote: > > Hello, Patrick. > > > > On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > > > However, the "best effort" bandwidth control we have for CFS and RT >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-26 Thread Joel Fernandes
On Tue, Jul 24, 2018 at 06:29:02AM -0700, Tejun Heo wrote: > Hello, Patrick. > > On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > > However, the "best effort" bandwidth control we have for CFS and RT > > can be further improved if, instead of just looking at time spent on > >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-26 Thread Joel Fernandes
On Tue, Jul 24, 2018 at 06:29:02AM -0700, Tejun Heo wrote: > Hello, Patrick. > > On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > > However, the "best effort" bandwidth control we have for CFS and RT > > can be further improved if, instead of just looking at time spent on > >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-24 Thread Patrick Bellasi
Hi Tejun, I apologize in advance for the (yet another) long reply, however I did my best hereafter to try to resume all the controversial points discussed so far. If you will have (one more time) the patience to go through the following text you'll find a set of precise clarifications and

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-24 Thread Patrick Bellasi
Hi Tejun, I apologize in advance for the (yet another) long reply, however I did my best hereafter to try to resume all the controversial points discussed so far. If you will have (one more time) the patience to go through the following text you'll find a set of precise clarifications and

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-24 Thread Tejun Heo
Hello, Patrick. On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > However, the "best effort" bandwidth control we have for CFS and RT > can be further improved if, instead of just looking at time spent on > CPUs, we provide some more hints to the scheduler to know at which >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-24 Thread Tejun Heo
Hello, Patrick. On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote: > However, the "best effort" bandwidth control we have for CFS and RT > can be further improved if, instead of just looking at time spent on > CPUs, we provide some more hints to the scheduler to know at which >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Patrick Bellasi
On 23-Jul 08:30, Tejun Heo wrote: > Hello, Hi Tejun! > On Mon, Jul 16, 2018 at 09:29:02AM +0100, Patrick Bellasi wrote: > > The cgroup's CPU controller allows to assign a specified (maximum) > > bandwidth to the tasks of a group. However this bandwidth is defined and > > enforced only on a

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Patrick Bellasi
On 23-Jul 08:30, Tejun Heo wrote: > Hello, Hi Tejun! > On Mon, Jul 16, 2018 at 09:29:02AM +0100, Patrick Bellasi wrote: > > The cgroup's CPU controller allows to assign a specified (maximum) > > bandwidth to the tasks of a group. However this bandwidth is defined and > > enforced only on a

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Tejun Heo
Hello, On Mon, Jul 16, 2018 at 09:29:02AM +0100, Patrick Bellasi wrote: > The cgroup's CPU controller allows to assign a specified (maximum) > bandwidth to the tasks of a group. However this bandwidth is defined and > enforced only on a temporal base, without considering the actual > frequency a

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Tejun Heo
Hello, On Mon, Jul 16, 2018 at 09:29:02AM +0100, Patrick Bellasi wrote: > The cgroup's CPU controller allows to assign a specified (maximum) > bandwidth to the tasks of a group. However this bandwidth is defined and > enforced only on a temporal base, without considering the actual > frequency a

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Patrick Bellasi
On 20-Jul 19:37, Suren Baghdasaryan wrote: > On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi > wrote: [...] > > +#ifdef CONFIG_UCLAMP_TASK_GROUP > > +static int cpu_util_min_write_u64(struct cgroup_subsys_state *css, > > + struct cftype *cftype, u64 min_value) >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-23 Thread Patrick Bellasi
On 20-Jul 19:37, Suren Baghdasaryan wrote: > On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi > wrote: [...] > > +#ifdef CONFIG_UCLAMP_TASK_GROUP > > +static int cpu_util_min_write_u64(struct cgroup_subsys_state *css, > > + struct cftype *cftype, u64 min_value) >

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-20 Thread Suren Baghdasaryan
On Fri, Jul 20, 2018 at 7:37 PM, Suren Baghdasaryan wrote: > On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi > wrote: >> The cgroup's CPU controller allows to assign a specified (maximum) >> bandwidth to the tasks of a group. However this bandwidth is defined and >> enforced only on a temporal

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-20 Thread Suren Baghdasaryan
On Fri, Jul 20, 2018 at 7:37 PM, Suren Baghdasaryan wrote: > On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi > wrote: >> The cgroup's CPU controller allows to assign a specified (maximum) >> bandwidth to the tasks of a group. However this bandwidth is defined and >> enforced only on a temporal

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-20 Thread Suren Baghdasaryan
On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi wrote: > The cgroup's CPU controller allows to assign a specified (maximum) > bandwidth to the tasks of a group. However this bandwidth is defined and > enforced only on a temporal base, without considering the actual > frequency a CPU is running

Re: [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-20 Thread Suren Baghdasaryan
On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi wrote: > The cgroup's CPU controller allows to assign a specified (maximum) > bandwidth to the tasks of a group. However this bandwidth is defined and > enforced only on a temporal base, without considering the actual > frequency a CPU is running

[PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-16 Thread Patrick Bellasi
The cgroup's CPU controller allows to assign a specified (maximum) bandwidth to the tasks of a group. However this bandwidth is defined and enforced only on a temporal base, without considering the actual frequency a CPU is running on. Thus, the amount of computation completed by a task within an

[PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller

2018-07-16 Thread Patrick Bellasi
The cgroup's CPU controller allows to assign a specified (maximum) bandwidth to the tasks of a group. However this bandwidth is defined and enforced only on a temporal base, without considering the actual frequency a CPU is running on. Thus, the amount of computation completed by a task within an