Re: [PATCH v2 09/12] mm,thp: reduce ifdef'ery for THP in generic code

2015-10-09 Thread Kirill A. Shutemov
On Tue, Sep 22, 2015 at 04:04:53PM +0530, Vineet Gupta wrote: > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > level #ifdef. Makes code more readable Makes sense. > - Per Andrew's suggestion removed the dummy implementations for !THP > in asm-generic/page-table.h to

Re: [PATCH v2 09/12] mm,thp: reduce ifdef'ery for THP in generic code

2015-10-09 Thread Kirill A. Shutemov
On Tue, Sep 22, 2015 at 04:04:53PM +0530, Vineet Gupta wrote: > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > level #ifdef. Makes code more readable Makes sense. > - Per Andrew's suggestion removed the dummy implementations for !THP > in asm-generic/page-table.h to