Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-08 Thread Henrik Rydberg
Hi Benson, > I have applied your patch, but I found I still need this line in my > driver, otherwise, there are no ABS type event supported. Should the > core set this bit as well since it's certainly going to be dealing > with ABS data? > > __set_bit(EV_ABS, input->evbit); Yes, that would make

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-08 Thread Henrik Rydberg
Hi Benson, I have applied your patch, but I found I still need this line in my driver, otherwise, there are no ABS type event supported. Should the core set this bit as well since it's certainly going to be dealing with ABS data? __set_bit(EV_ABS, input-evbit); Yes, that would make sense,

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
Hi Henrik, I have applied your patch, but I found I still need this line in my driver, otherwise, there are no ABS type event supported. Should the core set this bit as well since it's certainly going to be dealing with ABS data? __set_bit(EV_ABS, input->evbit); Otherwise, it works great on my

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
Hi Henrik, I have applied your patch, but I found I still need this line in my driver, otherwise, there are no ABS type event supported. Should the core set this bit as well since it's certainly going to be dealing with ABS data? __set_bit(EV_ABS, input-evbit); Otherwise, it works great on my

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-06 Thread Henrik Rydberg
Hi Benson, > This patch introduces a driver for Cypress All Points Addressable > I2C Trackpad, including the ones in 2012 Samsung Chromebooks. > > This device is compatible with MT protocol type B, providing identifiable > contacts. > > Signed-off-by: Dudley Du > Signed-off-by: Daniel Kurtz >

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-06 Thread Jean Delvare
On Wed, 5 Dec 2012 23:48:17 -0800, Dmitry Torokhov wrote: > Hi Benson, > > On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: > > This patch introduces a driver for Cypress All Points Addressable > > I2C Trackpad, including the ones in 2012 Samsung Chromebooks. > > > > This device is

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-06 Thread Jean Delvare
On Wed, 5 Dec 2012 23:48:17 -0800, Dmitry Torokhov wrote: Hi Benson, On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-06 Thread Henrik Rydberg
Hi Benson, This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Daniel

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Dmitry Torokhov
Hi Benson, On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: > This patch introduces a driver for Cypress All Points Addressable > I2C Trackpad, including the ones in 2012 Samsung Chromebooks. > > This device is compatible with MT protocol type B, providing identifiable > contacts. >

[PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du Signed-off-by: Daniel Kurtz Signed-off-by: Benson Leung

[PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Daniel Kurtz

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Dmitry Torokhov
Hi Benson, On Wed, Dec 05, 2012 at 04:48:19PM -0800, Benson Leung wrote: This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts.