Re: [PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-08-14 Thread Wolfram Sang
On Fri, Jul 28, 2017 at 01:45:58PM -0700, Brendan Higgins wrote: > 24xx BMCs have larger clock divider granularity which can cause problems > when trying to set them as 25xx clock dividers; this adds clock setting > code specific to 24xx. > > This also fixes a potential issue where clock dividers

Re: [PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-08-13 Thread Brendan Higgins
On Sat, Aug 12, 2017 at 4:30 AM, Wolfram Sang wrote: > >> That being said, I could implement this as a custom clock subclass, which >> would probably be cleaner that what I have done. > > Shall I wait for that one or do you want this patch to be included? > I don't mind, your call here... > Let's

Re: [PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-08-12 Thread Wolfram Sang
> That being said, I could implement this as a custom clock subclass, which > would probably be cleaner that what I have done. Shall I wait for that one or do you want this patch to be included? I don't mind, your call here... signature.asc Description: PGP signature

Re: [PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-07-28 Thread Brendan Higgins
On Fri, Jul 28, 2017 at 2:00 PM, Rick Altherr wrote: > Is clk_fractional_divider from include/linux/clk-provider.h appropriate here? > Alas, no. clk_fractional_divider is not flexible enough to specify the divider the way that it is represented in the Aspeed 24xx/25xx parts which have the divider

Re: [PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-07-28 Thread Rick Altherr
Is clk_fractional_divider from include/linux/clk-provider.h appropriate here? On Fri, Jul 28, 2017 at 1:57 PM, Rick Altherr wrote: > Is clk_fractional_divider from include/linux/clk-provider.h appropriate > here? > > On Fri, Jul 28, 2017 at 1:45 PM, Brendan Higgins > wrote: >> >> 24xx BMCs have

[PATCH v2 1/1] i2c: aspeed: add proper support fo 24xx clock params

2017-07-28 Thread Brendan Higgins
24xx BMCs have larger clock divider granularity which can cause problems when trying to set them as 25xx clock dividers; this adds clock setting code specific to 24xx. This also fixes a potential issue where clock dividers were rounded down instead of up. Signed-off-by: Brendan Higgins --- Chang