Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Akinobu Mita
2019年9月28日(土) 2:46 Greg Kroah-Hartman : > > On Sat, Sep 28, 2019 at 01:47:21AM +0900, Akinobu Mita wrote: > > 2019年9月27日(金) 15:39 Greg Kroah-Hartman : > > > > > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > > > > Reading /sys/class/leds//trigger returns all available LED > > >

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Greg Kroah-Hartman
On Sat, Sep 28, 2019 at 01:47:21AM +0900, Akinobu Mita wrote: > 2019年9月27日(金) 15:39 Greg Kroah-Hartman : > > > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > > > Reading /sys/class/leds//trigger returns all available LED triggers. > > > However, the size of this file is limited

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Pavel Machek
Hi! > > > down_read(_list_lock); > > > down_read(_cdev->trigger_lock); > > > > > > - if (!led_cdev->trigger) > > > - len += scnprintf(buf+len, PAGE_SIZE - len, "[none] "); > > > + len = led_trigger_format(NULL, 0, true, led_cdev); > > > + data = kvmalloc(len +

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Akinobu Mita
2019年9月27日(金) 15:39 Greg Kroah-Hartman : > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > > Reading /sys/class/leds//trigger returns all available LED triggers. > > However, the size of this file is limited to PAGE_SIZE because of the > > limitation for sysfs attribute. > > > >

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Greg Kroah-Hartman
On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > Reading /sys/class/leds//trigger returns all available LED triggers. > However, the size of this file is limited to PAGE_SIZE because of the > limitation for sysfs attribute. > > Enabling LED CPU trigger on systems with thousands of

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-27 Thread Greg Kroah-Hartman
On Tue, Sep 24, 2019 at 11:30:08PM +0200, Jacek Anaszewski wrote: > Hi Greg, > > Akinobu seems to have addressed all issues that have been > raised regarding this patch. I'd be happy to have your ack before > applying it. You have to wait until after -rc1 is out before doing anything, so there's

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-24 Thread Jacek Anaszewski
Hi Greg, Akinobu seems to have addressed all issues that have been raised regarding this patch. I'd be happy to have your ack before applying it. Best regards, Jacek Anaszewski On 9/13/19 5:03 PM, Akinobu Mita wrote: > Reading /sys/class/leds//trigger returns all available LED triggers. >

[PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-13 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute. Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all