Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Andy Shevchenko
On Sat, Mar 4, 2017 at 1:23 AM, James Hogan wrote: > On Fri, Mar 03, 2017 at 03:31:06PM +0200, Andy Shevchenko wrote: >> On Fri, 2017-03-03 at 00:21 +, James Hogan wrote: >> > The CONFIG_HAVE_CLK=n implementation of devm_clk_get() in particular >> > seems highly questionable to me, given that

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread James Hogan
st ; David Daney > ; Russell King ; > linux-...@vger.kernel.org; Viresh Kumar > Subject: Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to > be used > > Hi Jason, > > On Fri, Mar 03, 2017 at 09:43:55AM -0800, Jason Uy wrote: > > James, > &g

RE: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Jason Uy
l King ; linux-...@vger.kernel.org; Viresh Kumar Subject: Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used Hi Jason, On Fri, Mar 03, 2017 at 09:43:55AM -0800, Jason Uy wrote: > James, > > Can you verify that changing the code to the following fixes your problem?

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread James Hogan
On Fri, Mar 03, 2017 at 03:31:06PM +0200, Andy Shevchenko wrote: > On Fri, 2017-03-03 at 00:21 +, James Hogan wrote: > > The CONFIG_HAVE_CLK=n implementation of devm_clk_get() in particular > > seems highly questionable to me, given that commit 93abe8e4b13a ("clk: > > add non CONFIG_HAVE_CLK ro

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread James Hogan
Camus ; Heikki Krogerus > ; Wang Hongcheng ; > linux-ser...@vger.kernel.org; LKML ; > bcm-kernel-feedback-l...@broadcom.com; Linux MIPS Mailing List > ; David Daney ; Russell > King ; linux-...@vger.kernel.org; Viresh Kumar > > Subject: Re: [PATCH v2 1/1] serial: 8250_dw: Allow

RE: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Jason Uy
Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used Hi Andy/Jason, On 3/3/2017 5:31 AM, Andy Shevchenko wrote: > Heiko, you might be interested in this as well. > > On Fri, 2017-03-03 at 00:21 +, James Hogan wrote: >> On Wed, Mar 01, 2017 at 08:50:20PM +020

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Ray Jui
Hi Andy/Jason, On 3/3/2017 5:31 AM, Andy Shevchenko wrote: > Heiko, you might be interested in this as well. > > On Fri, 2017-03-03 at 00:21 +, James Hogan wrote: >> On Wed, Mar 01, 2017 at 08:50:20PM +0200, Andy Shevchenko wrote: >>> On Wed, 2017-03-01 at 18:02 +, James Hogan wrote:

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Andy Shevchenko
Heiko, you might be interested in this as well. On Fri, 2017-03-03 at 00:21 +, James Hogan wrote: > On Wed, Mar 01, 2017 at 08:50:20PM +0200, Andy Shevchenko wrote: > > On Wed, 2017-03-01 at 18:02 +, James Hogan wrote: > > > On 11 January 2017 at 19:48, Jason Uy > > > wrote: > > > > In th

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-02 Thread James Hogan
On Wed, Mar 01, 2017 at 08:50:20PM +0200, Andy Shevchenko wrote: > On Wed, 2017-03-01 at 18:02 +, James Hogan wrote: > > On 11 January 2017 at 19:48, Jason Uy wrote: > > > In the most common use case, the Synopsys DW UART driver does not > > > set the set_termios callback function.  This preve

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-01 Thread Andy Shevchenko
On Wed, 2017-03-01 at 18:02 +, James Hogan wrote: > On 11 January 2017 at 19:48, Jason Uy wrote: > > In the most common use case, the Synopsys DW UART driver does not > > set the set_termios callback function.  This prevents UPSTAT_AUTOCTS > > from being set when the UART flag CRTSCTS is set. 

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-01-12 Thread Kefeng Wang
On 2017/1/12 3:48, Jason Uy wrote: > In the most common use case, the Synopsys DW UART driver does not > set the set_termios callback function. This prevents UPSTAT_AUTOCTS > from being set when the UART flag CRTSCTS is set. As a result, the > driver will use software flow control as opposed to

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-01-11 Thread Andy Shevchenko
On Wed, 2017-01-11 at 11:48 -0800, Jason Uy wrote: > In the most common use case, the Synopsys DW UART driver does not > set the set_termios callback function.  This prevents UPSTAT_AUTOCTS > from being set when the UART flag CRTSCTS is set.  As a result, the > driver will use software flow control

[PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-01-11 Thread Jason Uy
In the most common use case, the Synopsys DW UART driver does not set the set_termios callback function. This prevents UPSTAT_AUTOCTS from being set when the UART flag CRTSCTS is set. As a result, the driver will use software flow control as opposed to hardware flow control. To fix the problem,