Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread hl
On Monday, September 04, 2017 06:03 PM, Arnaud Pouliquen wrote: Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: From: huang lin

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread hl
On Monday, September 04, 2017 06:03 PM, Arnaud Pouliquen wrote: Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: From: huang lin

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread Mark Brown
On Mon, Sep 04, 2017 at 12:03:21PM +0200, Arnaud Pouliquen wrote: > > +static const struct snd_soc_dai_ops dmic_dai_ops = { > > + .trigger= dmic_daiops_trigger, > > +}; > should it be handle by trigger or DAPM? DAPM is a bit better, yes. I don't think it matters *overly* much in this

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread Mark Brown
On Mon, Sep 04, 2017 at 12:03:21PM +0200, Arnaud Pouliquen wrote: > > +static const struct snd_soc_dai_ops dmic_dai_ops = { > > + .trigger= dmic_daiops_trigger, > > +}; > should it be handle by trigger or DAPM? DAPM is a bit better, yes. I don't think it matters *overly* much in this

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread Arnaud Pouliquen
Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: > From: huang lin > > on some board use enable pin to control

Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-09-04 Thread Arnaud Pouliquen
Hello Lin, Sorry for this late answer. I'm not maintainer, just a contributor... but as some update seems strange for me, so i prefer to highlight it to clarify them. On 08/17/2017 04:24 AM, Lin Huang wrote: > From: huang lin > > on some board use enable pin to control dmic start and stop, >

[PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-08-16 Thread Lin Huang
From: huang lin on some board use enable pin to control dmic start and stop, so add this feature in dmic driver. Signed-off-by: Lin Huang --- sound/soc/codecs/Kconfig | 2 +- sound/soc/codecs/dmic.c | 46

[PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

2017-08-16 Thread Lin Huang
From: huang lin on some board use enable pin to control dmic start and stop, so add this feature in dmic driver. Signed-off-by: Lin Huang --- sound/soc/codecs/Kconfig | 2 +- sound/soc/codecs/dmic.c | 46 ++ 2 files changed, 47 insertions(+), 1