Re: [PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Maciej S. Szmigiero
On 06.01.2021 20:03, Ben Gardon wrote: On Wed, Jan 6, 2021 at 10:59 AM Ben Gardon wrote: Many TDP MMU functions which need to perform some action on all TDP MMU roots hold a reference on that root so that they can safely drop the MMU lock in order to yield to other threads. However, when

Re: [PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Sean Christopherson
On Wed, Jan 06, 2021, Ben Gardon wrote: > Many TDP MMU functions which need to perform some action on all TDP MMU > roots hold a reference on that root so that they can safely drop the MMU > lock in order to yield to other threads. However, when releasing the > reference on the root, there is a

Re: [PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Ben Gardon
On Wed, Jan 6, 2021 at 10:59 AM Ben Gardon wrote: > > Many TDP MMU functions which need to perform some action on all TDP MMU > roots hold a reference on that root so that they can safely drop the MMU > lock in order to yield to other threads. However, when releasing the > reference on the root,

[PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Ben Gardon
Many TDP MMU functions which need to perform some action on all TDP MMU roots hold a reference on that root so that they can safely drop the MMU lock in order to yield to other threads. However, when releasing the reference on the root, there is a bug: the root will not be freed even if its