Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-16 Thread Brian Norris
Hi all, I believe Philippe's comments about return values have been addressed separately, and this patch was applied to drm-misc-next. But I have one additional thought below. On Tue, Jan 09, 2018 at 12:32:47PM -0800, Brian Norris wrote: > This takes care of 2 TODOs in this driver, by using the c

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-15 Thread Archit Taneja
On 01/10/2018 02:02 AM, Brian Norris wrote: This takes care of 2 TODOs in this driver, by using the common DSI packet-marshalling code instead of our custom short/long write code. This both saves us some duplicated code and gets us free support for command types that weren't already part of our

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-11 Thread Andrzej Hajda
On 11.01.2018 14:51, Philippe CORNU wrote: > Hi Brian & All *DSI DRM experts*, > > 1) Re-reading this patch, I realize that the returned value of > dw_mipi_dsi_host_transfer() is not correct: we should return the number > of transfered/received bytes... > > so I think there are two solutions: fix

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-11 Thread Philippe CORNU
Hi Brian & All *DSI DRM experts*, 1) Re-reading this patch, I realize that the returned value of dw_mipi_dsi_host_transfer() is not correct: we should return the number of transfered/received bytes... so I think there are two solutions: fix this in this serie or add a TODO for later (both solu

[PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-09 Thread Brian Norris
This takes care of 2 TODOs in this driver, by using the common DSI packet-marshalling code instead of our custom short/long write code. This both saves us some duplicated code and gets us free support for command types that weren't already part of our switch block (e.g., MIPI_DSI_GENERIC_LONG_WRITE