Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-10 Thread Dan Murphy 
Pavel

Thanks for the review

On 05/10/2018 06:28 AM, Pavel Machek wrote:
> On Tue 2018-05-08 09:17:03, Dan Murphy wrote:
>> Introduce the device tree bindings for the lm3601x
>> family of LED torch, flash and IR drivers.
>>
>> Signed-off-by: Dan Murphy 
>> ---
>>
>> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
>>
>>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
>> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> new file mode 100644
>> index ..38cdabf6ca7e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> @@ -0,0 +1,51 @@
>> +* Texas Instruments - lm3601x Single-LED Flash Driver
>> +
>> +The LM3601X are ultra-small LED flash drivers that
>> +provides a high level of adjustability.
> 
> "provide".

Data sheet says provides.

It reads fine either way but I will change it.

> 
>> +Required properties:
>> +- compatible : Can be one of the following
>> +"ti,lm3601x"
>> +"ti,lm36010"
>> +"ti,lm36011"
>> +- reg : I2C slave address
>> +- #address-cells : 1
>> +- #size-cells : 0
>> +
>> +Required child properties:
>> +- reg : 0 - Indicates to support and register a torch interface
>> +1 - Indicates to support and register a strobe interface
>> +2 - Indicates to support and register an ir interface
> 
> I'd delete "to support and register" -- we are describing hardware here.

OK

> 
>> +Optional child properties:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +led-controller@64 {
>> +compatible = "ti,lm3601x";
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +reg = <0x64>;
>> +
>> +led@0 {
>> +reg = <0>;
>> +label = "white:torch";
>> +led-max-microamp=<1>;
>> +};
>> +
>> +led@1 {
>> +reg = <1>;
>> +label = "white:strobe";
>> +flash-max-microamp=<1>;
>> +flash-max-timeout-us=<800>;
>> +};
>> +
>> +led@2 {
>> +reg = <2>;
>> +label = "invisible:ir";
>> +};
>> +}
> 
> Title says this is single-LED driver chip, but it controls three chips
> in this example?

3 chips?  It technically controls 3 LED methods and only 2 LEDs.  The torch can 
be used as the strobe
and the IR is controlled independently.

> 
> I'd put " " around "=" for consistency.

OK

> 
> We use "flash" elsewhere, I'd replace "strobe" with that. Userspace
> would like consistency, too.

Labels are meant to be examples only not absolutes.  I will change it to say 
flash
but the label can be anything the customer wants it to be.

> 
> What is the IR led good for? Taking videos in the dark?

Yes.  That is one application.
And hunting ghosts ;)

> 
> I guess for consistency, it is "ir:torch" :-).

OK

> 
>   Pavel
> 


-- 
--
Dan Murphy

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-10 Thread Dan Murphy 
Pavel

Thanks for the review

On 05/10/2018 06:28 AM, Pavel Machek wrote:
> On Tue 2018-05-08 09:17:03, Dan Murphy wrote:
>> Introduce the device tree bindings for the lm3601x
>> family of LED torch, flash and IR drivers.
>>
>> Signed-off-by: Dan Murphy 
>> ---
>>
>> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
>>
>>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
>> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> new file mode 100644
>> index ..38cdabf6ca7e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> @@ -0,0 +1,51 @@
>> +* Texas Instruments - lm3601x Single-LED Flash Driver
>> +
>> +The LM3601X are ultra-small LED flash drivers that
>> +provides a high level of adjustability.
> 
> "provide".

Data sheet says provides.

It reads fine either way but I will change it.

> 
>> +Required properties:
>> +- compatible : Can be one of the following
>> +"ti,lm3601x"
>> +"ti,lm36010"
>> +"ti,lm36011"
>> +- reg : I2C slave address
>> +- #address-cells : 1
>> +- #size-cells : 0
>> +
>> +Required child properties:
>> +- reg : 0 - Indicates to support and register a torch interface
>> +1 - Indicates to support and register a strobe interface
>> +2 - Indicates to support and register an ir interface
> 
> I'd delete "to support and register" -- we are describing hardware here.

OK

> 
>> +Optional child properties:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +led-controller@64 {
>> +compatible = "ti,lm3601x";
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +reg = <0x64>;
>> +
>> +led@0 {
>> +reg = <0>;
>> +label = "white:torch";
>> +led-max-microamp=<1>;
>> +};
>> +
>> +led@1 {
>> +reg = <1>;
>> +label = "white:strobe";
>> +flash-max-microamp=<1>;
>> +flash-max-timeout-us=<800>;
>> +};
>> +
>> +led@2 {
>> +reg = <2>;
>> +label = "invisible:ir";
>> +};
>> +}
> 
> Title says this is single-LED driver chip, but it controls three chips
> in this example?

3 chips?  It technically controls 3 LED methods and only 2 LEDs.  The torch can 
be used as the strobe
and the IR is controlled independently.

> 
> I'd put " " around "=" for consistency.

OK

> 
> We use "flash" elsewhere, I'd replace "strobe" with that. Userspace
> would like consistency, too.

Labels are meant to be examples only not absolutes.  I will change it to say 
flash
but the label can be anything the customer wants it to be.

> 
> What is the IR led good for? Taking videos in the dark?

Yes.  That is one application.
And hunting ghosts ;)

> 
> I guess for consistency, it is "ir:torch" :-).

OK

> 
>   Pavel
> 


-- 
--
Dan Murphy

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-10 Thread Pavel Machek 
On Tue 2018-05-08 09:17:03, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
> 
> Signed-off-by: Dan Murphy 
> ---
> 
> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
> 
>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> new file mode 100644
> index ..38cdabf6ca7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,51 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver
> +
> +The LM3601X are ultra-small LED flash drivers that
> +provides a high level of adjustability.

"provide".

> +Required properties:
> + - compatible : Can be one of the following
> + "ti,lm3601x"
> + "ti,lm36010"
> + "ti,lm36011"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Required child properties:
> + - reg : 0 - Indicates to support and register a torch interface
> + 1 - Indicates to support and register a strobe interface
> + 2 - Indicates to support and register an ir interface

I'd delete "to support and register" -- we are describing hardware here.

> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +led-controller@64 {
> + compatible = "ti,lm3601x";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp=<1>;
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "white:strobe";
> + flash-max-microamp=<1>;
> + flash-max-timeout-us=<800>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "invisible:ir";
> + };
> +}

Title says this is single-LED driver chip, but it controls three chips
in this example?

I'd put " " around "=" for consistency.

We use "flash" elsewhere, I'd replace "strobe" with that. Userspace
would like consistency, too.

What is the IR led good for? Taking videos in the dark?

I guess for consistency, it is "ir:torch" :-).

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-10 Thread Pavel Machek 
On Tue 2018-05-08 09:17:03, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
> 
> Signed-off-by: Dan Murphy 
> ---
> 
> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
> 
>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> new file mode 100644
> index ..38cdabf6ca7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,51 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver
> +
> +The LM3601X are ultra-small LED flash drivers that
> +provides a high level of adjustability.

"provide".

> +Required properties:
> + - compatible : Can be one of the following
> + "ti,lm3601x"
> + "ti,lm36010"
> + "ti,lm36011"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Required child properties:
> + - reg : 0 - Indicates to support and register a torch interface
> + 1 - Indicates to support and register a strobe interface
> + 2 - Indicates to support and register an ir interface

I'd delete "to support and register" -- we are describing hardware here.

> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +led-controller@64 {
> + compatible = "ti,lm3601x";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp=<1>;
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "white:strobe";
> + flash-max-microamp=<1>;
> + flash-max-timeout-us=<800>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "invisible:ir";
> + };
> +}

Title says this is single-LED driver chip, but it controls three chips
in this example?

I'd put " " around "=" for consistency.

We use "flash" elsewhere, I'd replace "strobe" with that. Userspace
would like consistency, too.

What is the IR led good for? Taking videos in the dark?

I guess for consistency, it is "ir:torch" :-).

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Dan Murphy 
On 05/08/2018 10:32 AM, Andrew F. Davis wrote:
> On 05/08/2018 09:17 AM, Dan Murphy wrote:
>> Introduce the device tree bindings for the lm3601x
>> family of LED torch, flash and IR drivers.
>>
>> Signed-off-by: Dan Murphy 
>> ---
>>
>> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
>>
>>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
>> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> new file mode 100644
>> index ..38cdabf6ca7e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> @@ -0,0 +1,51 @@
>> +* Texas Instruments - lm3601x Single-LED Flash Driver
>> +
>> +The LM3601X are ultra-small LED flash drivers that
>> +provides a high level of adjustability.
>> +
>> +Required properties:
>> +- compatible : Can be one of the following
>> +"ti,lm3601x"
> 
> 
> No wildcard compatibles, drop this.

Yeah I hmm and hawed about keeping this so I figured I would get community 
feedback on this.
I can remove it.

> 
> 
>> +"ti,lm36010"
>> +"ti,lm36011"
>> +- reg : I2C slave address
>> +- #address-cells : 1
>> +- #size-cells : 0
>> +
>> +Required child properties:
>> +- reg : 0 - Indicates to support and register a torch interface
>> +1 - Indicates to support and register a strobe interface
>> +2 - Indicates to support and register an ir interface
>> +
>> +Optional child properties:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
> 
> 
> Relative path might work better here.

I was following the other LED documentation.

Pretty much a copy and paste

> 
> 
>> +Example:
>> +led-controller@64 {
>> +compatible = "ti,lm3601x";
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +reg = <0x64>;
>> +
>> +led@0 {
>> +reg = <0>;
>> +label = "white:torch";
>> +led-max-microamp=<1>;
>> +};
>> +
>> +led@1 {
>> +reg = <1>;
>> +label = "white:strobe";
>> +flash-max-microamp=<1>;
>> +flash-max-timeout-us=<800>;
>> +};
>> +
>> +led@2 {
>> +reg = <2>;
>> +label = "invisible:ir";
>> +};
>> +}
>> +
>> +For more product information please see the links below:
>> +http://www.ti.com/product/LM36010
>> +http://www.ti.com/product/LM36011
>>


-- 
--
Dan Murphy

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Dan Murphy 
On 05/08/2018 10:32 AM, Andrew F. Davis wrote:
> On 05/08/2018 09:17 AM, Dan Murphy wrote:
>> Introduce the device tree bindings for the lm3601x
>> family of LED torch, flash and IR drivers.
>>
>> Signed-off-by: Dan Murphy 
>> ---
>>
>> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
>>
>>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
>> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> new file mode 100644
>> index ..38cdabf6ca7e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>> @@ -0,0 +1,51 @@
>> +* Texas Instruments - lm3601x Single-LED Flash Driver
>> +
>> +The LM3601X are ultra-small LED flash drivers that
>> +provides a high level of adjustability.
>> +
>> +Required properties:
>> +- compatible : Can be one of the following
>> +"ti,lm3601x"
> 
> 
> No wildcard compatibles, drop this.

Yeah I hmm and hawed about keeping this so I figured I would get community 
feedback on this.
I can remove it.

> 
> 
>> +"ti,lm36010"
>> +"ti,lm36011"
>> +- reg : I2C slave address
>> +- #address-cells : 1
>> +- #size-cells : 0
>> +
>> +Required child properties:
>> +- reg : 0 - Indicates to support and register a torch interface
>> +1 - Indicates to support and register a strobe interface
>> +2 - Indicates to support and register an ir interface
>> +
>> +Optional child properties:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
> 
> 
> Relative path might work better here.

I was following the other LED documentation.

Pretty much a copy and paste

> 
> 
>> +Example:
>> +led-controller@64 {
>> +compatible = "ti,lm3601x";
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +reg = <0x64>;
>> +
>> +led@0 {
>> +reg = <0>;
>> +label = "white:torch";
>> +led-max-microamp=<1>;
>> +};
>> +
>> +led@1 {
>> +reg = <1>;
>> +label = "white:strobe";
>> +flash-max-microamp=<1>;
>> +flash-max-timeout-us=<800>;
>> +};
>> +
>> +led@2 {
>> +reg = <2>;
>> +label = "invisible:ir";
>> +};
>> +}
>> +
>> +For more product information please see the links below:
>> +http://www.ti.com/product/LM36010
>> +http://www.ti.com/product/LM36011
>>


-- 
--
Dan Murphy

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Andrew F. Davis 
On 05/08/2018 09:17 AM, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
> 
> Signed-off-by: Dan Murphy 
> ---
> 
> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
> 
>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> new file mode 100644
> index ..38cdabf6ca7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,51 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver
> +
> +The LM3601X are ultra-small LED flash drivers that
> +provides a high level of adjustability.
> +
> +Required properties:
> + - compatible : Can be one of the following
> + "ti,lm3601x"


No wildcard compatibles, drop this.


> + "ti,lm36010"
> + "ti,lm36011"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Required child properties:
> + - reg : 0 - Indicates to support and register a torch interface
> + 1 - Indicates to support and register a strobe interface
> + 2 - Indicates to support and register an ir interface
> +
> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +


Relative path might work better here.


> +Example:
> +led-controller@64 {
> + compatible = "ti,lm3601x";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp=<1>;
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "white:strobe";
> + flash-max-microamp=<1>;
> + flash-max-timeout-us=<800>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "invisible:ir";
> + };
> +}
> +
> +For more product information please see the links below:
> +http://www.ti.com/product/LM36010
> +http://www.ti.com/product/LM36011
>

Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Andrew F. Davis 
On 05/08/2018 09:17 AM, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
> 
> Signed-off-by: Dan Murphy 
> ---
> 
> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
> 
>  .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
> b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> new file mode 100644
> index ..38cdabf6ca7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,51 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver
> +
> +The LM3601X are ultra-small LED flash drivers that
> +provides a high level of adjustability.
> +
> +Required properties:
> + - compatible : Can be one of the following
> + "ti,lm3601x"


No wildcard compatibles, drop this.


> + "ti,lm36010"
> + "ti,lm36011"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Required child properties:
> + - reg : 0 - Indicates to support and register a torch interface
> + 1 - Indicates to support and register a strobe interface
> + 2 - Indicates to support and register an ir interface
> +
> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +


Relative path might work better here.


> +Example:
> +led-controller@64 {
> + compatible = "ti,lm3601x";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp=<1>;
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "white:strobe";
> + flash-max-microamp=<1>;
> + flash-max-timeout-us=<800>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "invisible:ir";
> + };
> +}
> +
> +For more product information please see the links below:
> +http://www.ti.com/product/LM36010
> +http://www.ti.com/product/LM36011
>

[PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Dan Murphy 
Introduce the device tree bindings for the lm3601x
family of LED torch, flash and IR drivers.

Signed-off-by: Dan Murphy 
---

v2 - No changes - https://patchwork.kernel.org/patch/10384587/

 .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
new file mode 100644
index ..38cdabf6ca7e
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
@@ -0,0 +1,51 @@
+* Texas Instruments - lm3601x Single-LED Flash Driver
+
+The LM3601X are ultra-small LED flash drivers that
+provides a high level of adjustability.
+
+Required properties:
+   - compatible : Can be one of the following
+   "ti,lm3601x"
+   "ti,lm36010"
+   "ti,lm36011"
+   - reg : I2C slave address
+   - #address-cells : 1
+   - #size-cells : 0
+
+Required child properties:
+   - reg : 0 - Indicates to support and register a torch interface
+   1 - Indicates to support and register a strobe interface
+   2 - Indicates to support and register an ir interface
+
+Optional child properties:
+   - label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+led-controller@64 {
+   compatible = "ti,lm3601x";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x64>;
+
+   led@0 {
+   reg = <0>;
+   label = "white:torch";
+   led-max-microamp=<1>;
+   };
+
+   led@1 {
+   reg = <1>;
+   label = "white:strobe";
+   flash-max-microamp=<1>;
+   flash-max-timeout-us=<800>;
+   };
+
+   led@2 {
+   reg = <2>;
+   label = "invisible:ir";
+   };
+}
+
+For more product information please see the links below:
+http://www.ti.com/product/LM36010
+http://www.ti.com/product/LM36011
-- 
2.17.0.252.gfe0a9eaf3

[PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

2018-05-08 Thread Dan Murphy 
Introduce the device tree bindings for the lm3601x
family of LED torch, flash and IR drivers.

Signed-off-by: Dan Murphy 
---

v2 - No changes - https://patchwork.kernel.org/patch/10384587/

 .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt 
b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
new file mode 100644
index ..38cdabf6ca7e
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
@@ -0,0 +1,51 @@
+* Texas Instruments - lm3601x Single-LED Flash Driver
+
+The LM3601X are ultra-small LED flash drivers that
+provides a high level of adjustability.
+
+Required properties:
+   - compatible : Can be one of the following
+   "ti,lm3601x"
+   "ti,lm36010"
+   "ti,lm36011"
+   - reg : I2C slave address
+   - #address-cells : 1
+   - #size-cells : 0
+
+Required child properties:
+   - reg : 0 - Indicates to support and register a torch interface
+   1 - Indicates to support and register a strobe interface
+   2 - Indicates to support and register an ir interface
+
+Optional child properties:
+   - label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+led-controller@64 {
+   compatible = "ti,lm3601x";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x64>;
+
+   led@0 {
+   reg = <0>;
+   label = "white:torch";
+   led-max-microamp=<1>;
+   };
+
+   led@1 {
+   reg = <1>;
+   label = "white:strobe";
+   flash-max-microamp=<1>;
+   flash-max-timeout-us=<800>;
+   };
+
+   led@2 {
+   reg = <2>;
+   label = "invisible:ir";
+   };
+}
+
+For more product information please see the links below:
+http://www.ti.com/product/LM36010
+http://www.ti.com/product/LM36011
-- 
2.17.0.252.gfe0a9eaf3