Re: [PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-21 Thread Rob Herring
On Sun, Jan 20, 2019 at 7:48 PM Joel Stanley wrote: > > On Sat, 19 Jan 2019 at 02:12, Tomer Maimon wrote: > > > > Hi Joel, > > > > Thanks for bringing this to my attention, > > > > I think I will leave it the same way it is now because I will like to > > develop the reset driver and to handle

Re: [PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-20 Thread Joel Stanley
On Sat, 19 Jan 2019 at 02:12, Tomer Maimon wrote: > > Hi Joel, > > Thanks for bringing this to my attention, > > I think I will leave it the same way it is now because I will like to develop > the reset driver and to handle the NPCM7xx SOC resets. You could also do that. But I was suggesting

Re: [PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-15 Thread Joel Stanley
On Thu, 10 Jan 2019 at 03:44, Tomer Maimon wrote: > +Required Node in the NPCM7xx BMC: > +An additional register is present in the NPCM7xx SOC which is > +assumed to be in the same device tree, with and marked as > +compatible with "nuvoton,npcm750-rst". Is there a reason you don't include a

Re: [PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-15 Thread Rob Herring
On Wed, 9 Jan 2019 18:43:42 +0200, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Analog-to-Digital Converter(ADC). > > Signed-off-by: Tomer Maimon > --- > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 > ++ > 1 file changed,

Re: [PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-12 Thread Jonathan Cameron
On Wed, 9 Jan 2019 18:43:42 +0200 Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Analog-to-Digital Converter(ADC). > > Signed-off-by: Tomer Maimon This looks fine to me, but I would like Rob's confirmation that he is happy with the reset part in

[PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-09 Thread Tomer Maimon
Added device tree binding documentation for Nuvoton BMC NPCM Analog-to-Digital Converter(ADC). Signed-off-by: Tomer Maimon --- .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644