Re: [PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-06 Thread Petr Mladek
On Fri 2015-03-06 08:54:23, Josh Poimboeuf wrote: On Fri, Mar 06, 2015 at 03:00:13PM +0100, Petr Mladek wrote: This brings me back to the original idea with that boolean that marks the state before and after the coming notifier (module_init). We could use a bitfield instead of the two

Re: [PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-06 Thread Josh Poimboeuf
On Fri, Mar 06, 2015 at 03:00:13PM +0100, Petr Mladek wrote: This brings me back to the original idea with that boolean that marks the state before and after the coming notifier (module_init). We could use a bitfield instead of the two booleans when requested. Yeah, that would work. Though I

Re: [PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-06 Thread Petr Mladek
On Fri 2015-03-06 11:20:32, Petr Mladek wrote: On Thu 2015-03-05 13:34:33, Josh Poimboeuf wrote: On Thu, Mar 05, 2015 at 04:45:13PM +0100, Petr Mladek wrote: Existing live patches are applied to loaded modules using a notify handler. There are two problems with this approach.

Re: [PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-06 Thread Petr Mladek
On Thu 2015-03-05 13:34:33, Josh Poimboeuf wrote: On Thu, Mar 05, 2015 at 04:45:13PM +0100, Petr Mladek wrote: Existing live patches are applied to loaded modules using a notify handler. There are two problems with this approach. First, errors from module notifiers are ignored and could

Re: [PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-05 Thread Josh Poimboeuf
On Thu, Mar 05, 2015 at 04:45:13PM +0100, Petr Mladek wrote: Existing live patches are applied to loaded modules using a notify handler. There are two problems with this approach. First, errors from module notifiers are ignored and could not stop the module from being loaded. But we will

[PATCH v2 1/2] livepatch/module: Apply patch when loaded module is unformed

2015-03-05 Thread Petr Mladek
Existing live patches are applied to loaded modules using a notify handler. There are two problems with this approach. First, errors from module notifiers are ignored and could not stop the module from being loaded. But we will need to refuse the module when there are semantics dependencies