Re: [PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Oscar Salvador
On 2021-02-19 03:10, Mike Kravetz wrote: Those counts will be wrong as there are no huge pages on the node. I'll think about this more tomorrow. Pretty sure this is an issue, but I could be wrong. Just wanted to give a heads up. Yes, this is a problem, although the fixup would be to check

Re: [PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Mike Kravetz
On 2/18/21 4:00 AM, Oscar Salvador wrote: > alloc_contig_range will fail if it ever sees a HugeTLB page within the > range we are trying to allocate, even when that page is free and can be > easily reallocated. > This has proofed to be problematic for some users of alloc_contic_range, > e.g: CMA

[PATCH v2 1/2] mm: Make alloc_contig_range handle free hugetlb pages

2021-02-18 Thread Oscar Salvador
alloc_contig_range will fail if it ever sees a HugeTLB page within the range we are trying to allocate, even when that page is free and can be easily reallocated. This has proofed to be problematic for some users of alloc_contic_range, e.g: CMA and virtio-mem, where those would fail the call even