Re: [PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-10 Thread Doug Anderson
Hi, On Tue, Jan 9, 2018 at 11:37 PM, Caesar Wang wrote: > From: Shawn Lin > > It turns out that 5us isn't enough for all cases, so let's > retry some more times to wait for caldone. > > Signed-off-by: Shawn Lin > Tested-by: Ziyuan Xu > Signed-off-by: Caesar Wang > --- > > Changes in v2: > - p

Re: [PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-10 Thread Doug Anderson
Hi, This seems like a good idea to me. The fact that there was no polling loop here always seemed strange to me, but that's how the original code was structured and I personally never saw any problems with it. On Wed, Jan 10, 2018 at 2:49 AM, Shawn Lin wrote: > It turns out that 5us isn't enoug

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-10 Thread Shawn Lin
It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Reviewed-by: Brian Norris Tested-by: Caesar Wang Tested-by: Ziyuan Xu --- Changes in v2: - propagate the error and print it drivers/phy/rockchip/phy-rockchip-emmc.c

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-09 Thread Caesar Wang
From: Shawn Lin It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu Signed-off-by: Caesar Wang --- Changes in v2: - print the return valut with regmap_read_poll_timeout failing. drivers/phy/rock