Fine. Fine. I saw the 3/3 patch after I wrote the email. Anyway I
hope that my ranting has planted a seed of doubt and from now you will
begin to view "out" labels with suspicion which will eventually flourish
into the flower of hatred.
regards,
dan carpenter
--
To unsubscribe from this list:
Dan Carpenter writes:
> On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
>> vmbus_device_create() result is not being checked in vmbus_process_offer()
>> and
>> it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
>> additional duplication of
Dan Carpenter dan.carpen...@oracle.com writes:
On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
vmbus_device_create() result is not being checked in vmbus_process_offer()
and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication
Fine. Fine. I saw the 3/3 patch after I wrote the email. Anyway I
hope that my ranting has planted a seed of doubt and from now you will
begin to view out labels with suspicion which will eventually flourish
into the flower of hatred.
regards,
dan carpenter
--
To unsubscribe from this list:
On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
> "error" is a crap label name because it doesn't tell you what the code
> does. A better name is "err_free_chan" or something which talks about
> freeing the channel.
If you choose your label names correctly, then most of the time
On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
> vmbus_device_create() result is not being checked in vmbus_process_offer() and
> it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
> additional duplication of "free_channel(); return;" block.
>
>
vmbus_device_create() result is not being checked in vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication of "free_channel(); return;" block.
Reported-by: Jason Wang
Signed-off-by: Vitaly Kuznetsov
---
vmbus_device_create() result is not being checked in vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication of free_channel(); return; block.
Reported-by: Jason Wang jasow...@redhat.com
Signed-off-by: Vitaly Kuznetsov
On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
error is a crap label name because it doesn't tell you what the code
does. A better name is err_free_chan or something which talks about
freeing the channel.
If you choose your label names correctly, then most of the time you can
On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
vmbus_device_create() result is not being checked in vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication of free_channel(); return; block.
Reported-by:
10 matches
Mail list logo