Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Brain, Thanks for your reply. On 03/02/2018 10:32 AM, Brian Norris wrote: > >What about the 'else' case? Shouldn't we try to handle that? >i think the else case is for irq key, which would generate down and up >events in one irq, so it would use the same trigger type for all these 3

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Brain, Thanks for your reply. On 03/02/2018 10:32 AM, Brian Norris wrote: > >What about the 'else' case? Shouldn't we try to handle that? >i think the else case is for irq key, which would generate down and up >events in one irq, so it would use the same trigger type for all these 3

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi, On Fri, Feb 23, 2018 at 06:04:22PM +0800, Jeffy Chen wrote: > On 02/13/2018 06:13 AM, Brian Norris wrote: > > > > > > > > if (bdata->gpiod) { > > > >+int active_low = gpiod_is_active_low(bdata->gpiod); > > > >+ > > > > if (button->debounce_interval) { >

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi, On Fri, Feb 23, 2018 at 06:04:22PM +0800, Jeffy Chen wrote: > On 02/13/2018 06:13 AM, Brian Norris wrote: > > > > > > > > if (bdata->gpiod) { > > > >+int active_low = gpiod_is_active_low(bdata->gpiod); > > > >+ > > > > if (button->debounce_interval) { >

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Enric, Thanks for your reply. On 02/14/2018 06:25 AM, Enric Balletbo Serra wrote: Hi, 2018-02-13 19:25 GMT+01:00 Brian Norris : Hi Enric, On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: On 12/02/18 23:13, Brian Norris wrote: On Sat, Feb

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Enric, Thanks for your reply. On 02/14/2018 06:25 AM, Enric Balletbo Serra wrote: Hi, 2018-02-13 19:25 GMT+01:00 Brian Norris : Hi Enric, On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: On 12/02/18 23:13, Brian Norris wrote: On Sat, Feb 10, 2018 at 07:09:05PM

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Brian, Thanks for your reply. On 02/13/2018 06:13 AM, Brian Norris wrote: > >if (bdata->gpiod) { >+ int active_low = gpiod_is_active_low(bdata->gpiod); >+ >if (button->debounce_interval) { >error = gpiod_set_debounce(bdata->gpiod, >

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Brian, Thanks for your reply. On 02/13/2018 06:13 AM, Brian Norris wrote: > >if (bdata->gpiod) { >+ int active_low = gpiod_is_active_low(bdata->gpiod); >+ >if (button->debounce_interval) { >error = gpiod_set_debounce(bdata->gpiod, >

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi, 2018-02-13 19:25 GMT+01:00 Brian Norris : > Hi Enric, > > On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: >> On 12/02/18 23:13, Brian Norris wrote: >> > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: >> >> Add support for

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi, 2018-02-13 19:25 GMT+01:00 Brian Norris : > Hi Enric, > > On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: >> On 12/02/18 23:13, Brian Norris wrote: >> > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: >> >> Add support for specifying event actions to

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Enric, On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: > On 12/02/18 23:13, Brian Norris wrote: > > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: > >> Add support for specifying event actions to trigger wakeup when using > >> the gpio-keys input device as

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Enric, On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: > On 12/02/18 23:13, Brian Norris wrote: > > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: > >> Add support for specifying event actions to trigger wakeup when using > >> the gpio-keys input device as

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Jeffy, On 12/02/18 23:13, Brian Norris wrote: > Hi Jeffy, > > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: >> Add support for specifying event actions to trigger wakeup when using >> the gpio-keys input device as a wakeup source. >> >> This would allow the device to configure

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Jeffy, On 12/02/18 23:13, Brian Norris wrote: > Hi Jeffy, > > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: >> Add support for specifying event actions to trigger wakeup when using >> the gpio-keys input device as a wakeup source. >> >> This would allow the device to configure

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Jeffy, On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Hi Jeffy, On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

[PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Add support for specifying event actions to trigger wakeup when using the gpio-keys input device as a wakeup source. This would allow the device to configure when to wakeup the system. For example a gpio-keys input device for pen insert, may only want to wakeup the system when ejecting the pen.

[PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action

Add support for specifying event actions to trigger wakeup when using the gpio-keys input device as a wakeup source. This would allow the device to configure when to wakeup the system. For example a gpio-keys input device for pen insert, may only want to wakeup the system when ejecting the pen.